Refactor to typescript #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabLeRoux
reviewed
Jan 9, 2022
| @@ -16,7 +16,7 @@ jobs: | |||
| - run: yarn lint | |||
| - run: yarn test | |||
| - run: yarn build || { echo "build command should always succeed" ; exit 61; } | |||
| - run: yarn build --quiet && git diff --quiet action || { echo "action should be auto generated" ; exit 62; } | |||
| # - run: yarn build --quiet && git diff --quiet dist || { echo "dist should be auto generated" ; exit 62; } | |||
There was a problem hiding this comment.
should we just remove that line?
There was a problem hiding this comment.
Yea ideally we do check somehow that the dist files are generated along with the PR.
Perhaps auto-generate it pre-merge or after every push?
There was a problem hiding this comment.
I created a separate issue for this line: https://github.com/game-ci/unity-actions/issues/133
GabLeRoux
reviewed
Jan 9, 2022
GabLeRoux
reviewed
Jan 9, 2022
GabLeRoux
approved these changes
Jan 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Checklist