Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud runner develop - Stabilizes kubernetes provider #531

Merged
merged 219 commits into from
Feb 6, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
219 commits
Select commit Hold shift + click to select a range
e580bee
fixes
frostebite Mar 30, 2023
7474886
fixes
frostebite Mar 30, 2023
03435c5
fixes
frostebite Mar 30, 2023
a09b75a
fixes
frostebite Mar 30, 2023
d197881
fixes
frostebite Mar 30, 2023
9962206
check for startup message in workflows
frostebite May 7, 2023
5208eab
check for startup message in workflows
frostebite May 7, 2023
df3f3df
check for startup message in workflows
frostebite May 7, 2023
88f6a6d
check for startup message in workflows
frostebite May 7, 2023
0b9a28f
check for startup message in workflows
frostebite May 7, 2023
7d49733
check for startup message in workflows
frostebite May 9, 2023
9e36958
Update cloud-runner-ci-pipeline.yml
frostebite May 10, 2023
7ee1859
Update cloud-runner-ci-pipeline.yml
frostebite May 10, 2023
f46b387
no storage class specified
frostebite May 10, 2023
d21b193
log file path
frostebite May 13, 2023
9eed488
Merge branch 'cloud-runner-develop' of https://github.com/game-ci/uni…
frostebite May 13, 2023
6d7934f
log file path
frostebite May 13, 2023
1a5b953
log file path
frostebite May 13, 2023
4a4b472
log file path
frostebite May 13, 2023
ae9fef3
log file path
frostebite May 13, 2023
ade6d78
log file path
frostebite May 13, 2023
9102a7e
log file path
frostebite May 13, 2023
fcf7fde
log file path
frostebite May 13, 2023
12764c8
updates
frostebite May 13, 2023
4de8ca9
log file path
frostebite May 14, 2023
dc01a0d
latest develop
frostebite May 14, 2023
36dc42c
log file path
frostebite May 14, 2023
80ec2d0
log file path
frostebite May 14, 2023
a1120d0
Update package.json
frostebite May 14, 2023
0d7955f
log file path
frostebite May 14, 2023
45a1901
log file path
frostebite May 14, 2023
a6ec380
log file path
frostebite May 14, 2023
a86e483
log file path
frostebite May 14, 2023
1df6a12
log file path
frostebite May 14, 2023
d3b4f28
log file path
frostebite May 14, 2023
d0934cb
log file path
frostebite May 14, 2023
8e5ccae
log file path
frostebite May 14, 2023
fecb78d
log file path
frostebite May 14, 2023
68f787c
log file path
frostebite May 14, 2023
6f6ba10
log file path
frostebite May 14, 2023
ce6c1ca
log file path
frostebite May 15, 2023
aec5ebd
log file path
frostebite May 15, 2023
16284dc
log file path
frostebite May 15, 2023
8a501a6
stream logs through standard input and new remote client cli command
frostebite Jun 4, 2023
a485fb0
stream logs through standard input and new remote client cli command
frostebite Jun 4, 2023
79ddbbd
stream logs through standard input and new remote client cli command
frostebite Jun 5, 2023
fdde0de
stream logs through standard input and new remote client cli command
frostebite Jun 5, 2023
88fa5d2
stream logs through standard input and new remote client cli command
frostebite Jun 5, 2023
c366060
stream logs through standard input and new remote client cli command
frostebite Jun 5, 2023
1867dce
stream logs through standard input and new remote client cli command
frostebite Jun 5, 2023
d92ce4d
stream logs through standard input and new remote client cli command
frostebite Jun 5, 2023
83491d9
stream logs through standard input and new remote client cli command
frostebite Jun 5, 2023
d1a2969
stream logs through standard input and new remote client cli command
frostebite Jun 5, 2023
596f3fb
stream logs through standard input and new remote client cli command
frostebite Jun 5, 2023
76e8818
stream logs through standard input and new remote client cli command
frostebite Jun 5, 2023
9e7fad6
stream logs through standard input and new remote client cli command
frostebite Jun 5, 2023
8a3a366
stream logs through standard input and new remote client cli command
frostebite Jun 5, 2023
4793f6b
stream logs through standard input and new remote client cli command
frostebite Jun 5, 2023
6a52358
update pipeline to use k3s
frostebite Jun 26, 2023
654638c
version: 'latest'
frostebite Jun 26, 2023
383a40e
fixes
frostebite Jun 26, 2023
1040f80
disable aws pipe for now
frostebite Jul 5, 2023
ec2b38d
disable aws pipe for now
frostebite Jul 5, 2023
e488903
disable aws pipe for now
frostebite Jul 5, 2023
c1a199e
disable aws pipe for now
frostebite Jul 6, 2023
613d7cc
disable aws pipe for now
frostebite Jul 6, 2023
4128a15
disable aws pipe for now
frostebite Jul 10, 2023
3488cec
disable aws pipe for now
frostebite Jul 10, 2023
334afd8
disable aws pipe for now
frostebite Jul 10, 2023
cf758e2
disable aws pipe for now
frostebite Jul 10, 2023
50d7f57
disable aws pipe for now
frostebite Jul 10, 2023
2e2eae0
push k8s logs to LOG SERVICE IP
frostebite Jul 17, 2023
e404132
push k8s logs to LOG SERVICE IP
frostebite Jul 17, 2023
c77d0ba
push k8s logs to LOG SERVICE IP
frostebite Jul 17, 2023
8cafc65
push k8s logs to LOG SERVICE IP
frostebite Jul 17, 2023
7385dfe
push k8s logs to LOG SERVICE IP
frostebite Jul 17, 2023
e7802b9
push k8s logs to LOG SERVICE IP
frostebite Jul 17, 2023
37fc4c1
push k8s logs to LOG SERVICE IP
frostebite Jul 17, 2023
cd4fb29
push k8s logs to LOG SERVICE IP
frostebite Jul 17, 2023
e710d72
tests
frostebite Jul 19, 2023
0541b88
tests
frostebite Jul 21, 2023
7a488ec
tests
frostebite Jul 22, 2023
6757bcd
tests
frostebite Jul 22, 2023
219ae16
tests
frostebite Jul 22, 2023
27a1252
tests
frostebite Jul 22, 2023
fecae8e
tests
frostebite Jul 22, 2023
9fafb79
tests
frostebite Jul 22, 2023
5b8e2c7
tests
frostebite Jul 22, 2023
d881c3d
tests
frostebite Jul 22, 2023
8e6762e
tests
frostebite Jul 22, 2023
c3ec851
tests
frostebite Jul 23, 2023
7243511
tests
frostebite Jul 23, 2023
7506b71
tests
frostebite Jul 23, 2023
e73a8b4
tests
frostebite Jul 23, 2023
f52e8ce
tests
frostebite Jul 23, 2023
74b943e
tests
frostebite Jul 23, 2023
a275c2e
podname logs for log service
frostebite Aug 1, 2023
7d2704c
podname logs for log service
frostebite Aug 1, 2023
e7c48f6
podname logs for log service
frostebite Aug 2, 2023
1314055
podname logs for log service
frostebite Aug 2, 2023
2cb1914
podname logs for log service
frostebite Aug 11, 2023
0dd50cc
podname logs for log service
frostebite Aug 11, 2023
f889ac6
podname logs for log service
frostebite Aug 11, 2023
14819a6
podname logs for log service
frostebite Aug 11, 2023
2019e73
podname logs for log service
frostebite Aug 14, 2023
87c7a1f
hashed logs
frostebite Aug 14, 2023
358cf1c
hashed logs
frostebite Aug 14, 2023
4225feb
hashed logs
frostebite Aug 14, 2023
174bda8
hashed logs
frostebite Aug 14, 2023
debe473
hashed logs
frostebite Aug 14, 2023
c658a08
hashed logs
frostebite Aug 14, 2023
9900a91
no wait, just repeat logs
frostebite Aug 15, 2023
a31896b
no wait, just repeat logs
frostebite Aug 15, 2023
eba396b
no wait, just repeat logs
frostebite Aug 15, 2023
39392a1
remove typo - double await
frostebite Aug 17, 2023
964e77c
test fix - kubernetes - name typo in github yaml
frostebite Aug 17, 2023
2b1e4cb
test fix - kubernetes - name typo in github yaml
frostebite Aug 17, 2023
499ad87
check missing log file
frostebite Aug 18, 2023
c6b0f25
check missing log file
frostebite Aug 18, 2023
b489bd5
Push to steam test
frostebite Aug 19, 2023
c5580f8
Push to steam test
frostebite Aug 19, 2023
2e9e9df
Fix path
frostebite Aug 19, 2023
b91e21f
k8s reliable log hashing
frostebite Sep 18, 2023
2739d23
k8s reliable log hashing
frostebite Sep 18, 2023
b0b1cf8
k8s reliable log hashing
frostebite Sep 18, 2023
c0f9b06
hashed logging k8s
frostebite Sep 18, 2023
cc57add
hashed logging k8s
frostebite Sep 18, 2023
df456df
hashed logging k8s
frostebite Sep 19, 2023
51c1da5
hashed logging k8s
frostebite Sep 19, 2023
368f63e
hashed logging k8s
frostebite Sep 20, 2023
6bd6fdd
hashed logging k8s
frostebite Sep 20, 2023
b452c2b
Include log chunk when task runner sees log update, clarify if we can…
frostebite Sep 23, 2023
a760ee8
Include log chunk when task runner sees log update, clarify if we can…
frostebite Sep 23, 2023
5631a3b
Include log chunk when task runner sees log update, clarify if we can…
frostebite Sep 24, 2023
f563b8c
Include log chunk when task runner sees log update, clarify if we can…
frostebite Sep 25, 2023
534c94e
Include log chunk when task runner sees log update, clarify if we can…
frostebite Sep 25, 2023
6c6866f
Fix exit flow for k8s job
frostebite Sep 28, 2023
9cb8294
hash comparison logging for log complete in k8s flow
frostebite Oct 2, 2023
4b07216
Interrupt k8s logs when logs found
frostebite Oct 2, 2023
df4cc41
fixes
frostebite Nov 18, 2023
e296ef2
cleanup async parameter
frostebite Nov 18, 2023
dd13cba
cleanup async parameter
frostebite Nov 18, 2023
f547cb2
cleanup async parameter
frostebite Nov 18, 2023
b14cc24
latest main merged
frostebite Dec 1, 2023
e9336d7
fixes
frostebite Dec 6, 2023
bd3de93
fix
frostebite Dec 9, 2023
41f1f8b
fix
frostebite Dec 9, 2023
a624d7b
fix
frostebite Dec 9, 2023
8ca9214
fix
frostebite Dec 9, 2023
5d52c1d
fix
frostebite Dec 10, 2023
51919eb
Merge commit '9406bce8755d1903fa423d9b39de091ae2875506' into cloud-ru…
frostebite Dec 11, 2023
b4a6b75
fix
frostebite Dec 11, 2023
328bf4e
fix
frostebite Dec 20, 2023
115a9d4
fix
frostebite Dec 20, 2023
c3ec139
fix
frostebite Dec 21, 2023
5133a0b
fix
frostebite Dec 21, 2023
6dd49d6
fix
frostebite Dec 21, 2023
557c799
fix
frostebite Dec 21, 2023
94c9262
fix
frostebite Dec 21, 2023
3592835
fix
frostebite Dec 21, 2023
6ffa535
fix
frostebite Dec 21, 2023
b109ad0
fix
frostebite Dec 21, 2023
675443c
fix
frostebite Dec 21, 2023
dd76efe
fix
frostebite Dec 21, 2023
b595403
fix
frostebite Dec 21, 2023
1d38f8a
fix
frostebite Dec 21, 2023
6488cc3
fix
frostebite Dec 21, 2023
3733938
fix
frostebite Dec 21, 2023
5206ee7
fix
frostebite Dec 22, 2023
4ade890
fix
frostebite Dec 22, 2023
cdbb9e6
fix
frostebite Dec 22, 2023
c30f58b
fix
frostebite Jan 4, 2024
144045f
fix
frostebite Jan 7, 2024
f9b7a21
fix
frostebite Jan 7, 2024
37de5b2
fix
frostebite Jan 7, 2024
66947bd
fix
frostebite Jan 7, 2024
c262c92
fix
frostebite Jan 7, 2024
f5ba540
fix
frostebite Jan 7, 2024
0d70b4d
fix
frostebite Jan 7, 2024
a6f8859
fix
frostebite Jan 11, 2024
c13079a
fix
frostebite Jan 11, 2024
41c4f1c
fix
frostebite Jan 11, 2024
87b1587
fix
frostebite Jan 11, 2024
cdd1bd2
fix
frostebite Jan 12, 2024
74ad7d8
fix
frostebite Jan 19, 2024
71f94af
Merge branch 'main' into cloud-runner-develop
frostebite Jan 27, 2024
aaeb1d1
fix
frostebite Jan 27, 2024
e7dbd46
fix
frostebite Jan 27, 2024
38c3fbb
fix
frostebite Jan 27, 2024
fd181cc
fix
frostebite Jan 27, 2024
8f1f842
fix
frostebite Jan 27, 2024
48c6eef
fix
frostebite Jan 27, 2024
1a36e77
fix
frostebite Jan 29, 2024
5c870d9
fix
frostebite Jan 29, 2024
f8d0a49
fix
frostebite Jan 29, 2024
eb0a426
fix
frostebite Jan 30, 2024
3f48063
fix
frostebite Jan 30, 2024
07ed633
fix
frostebite Jan 30, 2024
1c9e51b
fix
frostebite Jan 30, 2024
b74fa7a
fix
frostebite Jan 30, 2024
e038adc
fix
frostebite Jan 30, 2024
44e887f
fix
frostebite Jan 30, 2024
620a730
fix
frostebite Jan 30, 2024
bb0b3bd
fix
frostebite Jan 31, 2024
f00c248
fix
frostebite Jan 31, 2024
9840db2
fix
frostebite Feb 1, 2024
18ed88c
fix
frostebite Feb 1, 2024
d493977
fix
frostebite Feb 4, 2024
345084e
fix
frostebite Feb 4, 2024
28b4f69
fix
frostebite Feb 5, 2024
d79587f
fix
frostebite Feb 5, 2024
2badcf5
fix
frostebite Feb 6, 2024
f8e3d73
fix
frostebite Feb 6, 2024
5c618dc
fix
frostebite Feb 6, 2024
cb0def7
fix
frostebite Feb 6, 2024
be427a5
fix
frostebite Feb 6, 2024
0682fae
fix
frostebite Feb 6, 2024
ca30440
fix
frostebite Feb 6, 2024
64e78ab
fix
frostebite Feb 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

- [x] Read the contribution [guide](https://github.com/game-ci/unity-builder/blob/main/CONTRIBUTING.md) and accept the
[code](https://github.com/game-ci/unity-builder/blob/main/CODE_OF_CONDUCT.md) of conduct
- [ ] Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make
a PR in the [documentation repo](https://github.com/game-ci/documentation))
- [ ] Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
in the [documentation repo](https://github.com/game-ci/documentation))
- [ ] Readme (updated or not needed)
- [ ] Tests (added, updated or not needed)
4 changes: 4 additions & 0 deletions .github/workflows/cloud-runner-ci-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ jobs:
name: Smoke Tests
if: github.event.event_type != 'pull_request_target'
runs-on: ubuntu-latest
env:
GIT_PRIVATE_TOKEN: ${{ secrets.GIT_PRIVATE_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
frostebite marked this conversation as resolved.
Show resolved Hide resolved
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -111,6 +114,7 @@ jobs:
- 'cloud-runner-environment'
#- 'cloud-runner-hooks'
- 'cloud-runner-s3-steps'
- 'cloud-runner-github-checks'
#- 'cloud-runner-local-persistence'
#- 'cloud-runner-locking-core'
#- 'cloud-runner-locking-get-locked'
Expand Down
4 changes: 2 additions & 2 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,11 +146,11 @@ inputs:
description:
'[CloudRunner] Either local, k8s or aws can be used to run builds on a remote cluster. Additional parameters must
be configured.'
cloudRunnerCpu:
containerCpu:
default: ''
required: false
description: '[CloudRunner] Amount of CPU time to assign the remote build container'
cloudRunnerMemory:
containerMemory:
default: ''
required: false
description: '[CloudRunner] Amount of memory to assign the remote build container'
Expand Down
55 changes: 36 additions & 19 deletions dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

20 changes: 14 additions & 6 deletions src/model/cloud-runner/cloud-runner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,7 @@ class CloudRunner {
CloudRunner.lockedWorkspace = ``;
}
}
const content = { ...CloudRunner.buildParameters };
content.gitPrivateToken = ``;
content.unitySerial = ``;
const jsonContent = JSON.stringify(content, undefined, 4);
await GitHub.updateGitHubCheck(jsonContent, CloudRunner.buildParameters.buildGuid);
await CloudRunner.updateStatusWithBuildParameters();
frostebite marked this conversation as resolved.
Show resolved Hide resolved
const output = await new WorkflowCompositionRoot().run(
new CloudRunnerStepParameters(
baseImage,
Expand All @@ -135,7 +131,9 @@ class CloudRunner {
);
CloudRunnerLogger.log(`Cleanup complete`);
if (!CloudRunner.buildParameters.isCliMode) core.endGroup();
await GitHub.updateGitHubCheck(CloudRunner.buildParameters.buildGuid, `success`, `success`, `completed`);
if ((buildParameters.asyncWorkflow && this.isCloudRunnerEnvironment) || !buildParameters.asyncWorkflow) {
await GitHub.updateGitHubCheck(CloudRunner.buildParameters.buildGuid, `success`, `success`, `completed`);
}

if (BuildParameters.shouldUseRetainedWorkspaceMode(buildParameters)) {
const workspace = CloudRunner.lockedWorkspace || ``;
Expand Down Expand Up @@ -176,5 +174,15 @@ class CloudRunner {
throw error;
}
}

private static async updateStatusWithBuildParameters() {
const content = { ...CloudRunner.buildParameters };
content.gitPrivateToken = ``;
content.unitySerial = ``;
content.unityEmail = ``;
content.unityPassword = ``;
const jsonContent = JSON.stringify(content, undefined, 4);
await GitHub.updateGitHubCheck(jsonContent, CloudRunner.buildParameters.buildGuid);
}
}
export default CloudRunner;
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import CloudRunner from '../../../cloud-runner';

export class TaskDefinitionFormation {
public static readonly description: string = `Game CI Cloud Runner Task Stack`;
public static readonly formation: string = `AWSTemplateFormatVersion: 2010-09-09
public static get formation(): string {
return `AWSTemplateFormatVersion: 2010-09-09
Description: ${TaskDefinitionFormation.description}
Parameters:
EnvironmentName:
Expand All @@ -26,11 +29,11 @@ Parameters:
Default: 80
Description: What port number the application inside the docker container is binding to
ContainerCpu:
Default: 1024
Default: ${CloudRunner.buildParameters.containerCpu}
Type: Number
Description: How much CPU to give the container. 1024 is 1 CPU
ContainerMemory:
Default: 4096
Default: ${CloudRunner.buildParameters.containerMemory}
Type: Number
Description: How much memory in megabytes to give the container
BUILDGUID:
Expand Down Expand Up @@ -92,7 +95,7 @@ Resources:
EFSVolumeConfiguration:
FilesystemId:
'Fn::ImportValue': !Sub '${'${EnvironmentName}'}:EfsFileStorageId'
TransitEncryption: ENABLED
TransitEncryption: DISABLED
RequiresCompatibilities:
- FARGATE
ExecutionRoleArn:
Expand Down Expand Up @@ -135,6 +138,7 @@ Resources:
DependsOn:
- LogGroup
`;
}
public static streamLogs = `
SubscriptionFilter:
Type: 'AWS::Logs::SubscriptionFilter'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,8 @@ class KubernetesJobSpecFactory {
preStop: {
exec: {
command: [
'bin/bash',
'-c',
`cd /data/builder/action/steps;
`wait 60s;
cd /data/builder/action/steps;
chmod +x /return_license.sh;
/return_license.sh;`,
],
Expand Down
2 changes: 1 addition & 1 deletion src/model/cloud-runner/remote-client/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export class RemoteClient {
if (!(await RemoteClient.handleRetainedWorkspace())) {
await RemoteClient.bootstrapRepository();
}
await RemoteClient.replaceLargePackageReferencesWithSharedReferences();
await RemoteClient.runCustomHookFiles(`before-build`);
}
static async runCustomHookFiles(hookLifecycle: string) {
Expand Down Expand Up @@ -47,7 +48,6 @@ export class RemoteClient {
`mkdir -p ${CloudRunnerFolders.ToLinuxFolder(CloudRunnerFolders.cacheFolderForCacheKeyFull)}`,
);
await RemoteClient.cloneRepoWithoutLFSFiles();
await RemoteClient.replaceLargePackageReferencesWithSharedReferences();
await RemoteClient.sizeOfFolder(
'repo before lfs cache pull',
CloudRunnerFolders.ToLinuxFolder(CloudRunnerFolders.repoPathAbsolute),
Expand Down
49 changes: 49 additions & 0 deletions src/model/cloud-runner/tests/cloud-runner-github-checks.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
import { BuildParameters } from '../..';
import CloudRunner from '../cloud-runner';
import UnityVersioning from '../../unity-versioning';
import { Cli } from '../../cli/cli';
import CloudRunnerOptions from '../options/cloud-runner-options';
import setups from './cloud-runner-suite.test';
import { OptionValues } from 'commander';
import GitHub from '../../github';

async function CreateParameters(overrides: OptionValues | undefined) {
if (overrides) Cli.options = overrides;

return BuildParameters.create();
}
describe('Cloud Runner Github Checks', () => {
setups();
it('Responds', () => {});

if (CloudRunnerOptions.cloudRunnerDebug && CloudRunnerOptions.providerStrategy === `local-docker`) {
it('Check Handling Direct', async () => {
// Setup parameters
const buildParameter = await CreateParameters({
versioning: 'None',
projectPath: 'test-project',
unityVersion: UnityVersioning.read('test-project'),
asyncCloudRunner: `true`,
githubChecks: `true`,
});
await CloudRunner.setup(buildParameter);
CloudRunner.buildParameters.githubCheckId = await GitHub.createGitHubCheck(`t`);
await GitHub.updateGitHubCheck(`t`, `t2`);
}, 1_000_000_000);
it('Check Handling Via Async Workflow', async () => {
// Setup parameters
const buildParameter = await CreateParameters({
versioning: 'None',
projectPath: 'test-project',
unityVersion: UnityVersioning.read('test-project'),
asyncCloudRunner: `true`,
githubChecks: `true`,
});
GitHub.asyncWorkflows = true;
await CloudRunner.setup(buildParameter);
CloudRunner.buildParameters.githubCheckId = await GitHub.createGitHubCheck(`t`);
await GitHub.updateGitHubCheck(`t`, `t2`);
GitHub.asyncWorkflows = false;
}, 1_000_000_000);
frostebite marked this conversation as resolved.
Show resolved Hide resolved
}
});
5 changes: 5 additions & 0 deletions src/model/cloud-runner/workflows/async-workflow.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ node /builder/dist/index.js -m async-workflow`,
[
...secrets,
...[
{
ParameterKey: `GITHUB_TOKEN`,
EnvironmentVariable: `GITHUB_TOKEN`,
ParameterValue: process.env.GITHUB_TOKEN || ``,
},
{
ParameterKey: `AWS_ACCESS_KEY_ID`,
EnvironmentVariable: `AWS_ACCESS_KEY_ID`,
Expand Down
3 changes: 2 additions & 1 deletion src/model/github.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ class GitHub {
private static startedDate: string;
private static endedDate: string;
static result: string = ``;
static asyncWorkflows: boolean;
private static get octokitDefaultToken() {
return new Octokit({
auth: process.env.GITHUB_TOKEN,
Expand Down Expand Up @@ -127,7 +128,7 @@ class GitHub {
data.conclusion = result;
}

await (CloudRunner.isCloudRunnerAsyncEnvironment
await (CloudRunner.isCloudRunnerAsyncEnvironment || GitHub.asyncWorkflows
? GitHub.runUpdateAsyncChecksWorkflow(data, `update`)
: GitHub.updateGitHubCheckRequest(data));
frostebite marked this conversation as resolved.
Show resolved Hide resolved
}
Expand Down