Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud runner develop - Stabilizes kubernetes provider #531

Merged
merged 219 commits into from
Feb 6, 2024

Conversation

frostebite
Copy link
Member

@frostebite frostebite commented Mar 30, 2023

Changes

Stabilizes kubernetes provider

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make
    a PR in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions
Copy link

Cat Gif

@frostebite frostebite force-pushed the cloud-runner-develop branch from 39a5592 to 22d282c Compare March 30, 2023 21:31
@frostebite frostebite changed the title Cloud runner develop Cloud runner develop - small fixes Mar 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Attention: 151 lines in your changes are missing coverage. Please review.

Comparison is base (2800d14) 37.40% compared to head (75cd577) 36.90%.

❗ Current head 75cd577 differs from pull request most recent head 0682fae. Consider uploading reports for the commit 0682fae to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
- Coverage   37.40%   36.90%   -0.50%     
==========================================
  Files          75       77       +2     
  Lines        3048     3116      +68     
  Branches      605      642      +37     
==========================================
+ Hits         1140     1150      +10     
+ Misses       1908     1823      -85     
- Partials        0      143     +143     
Files Coverage Δ
...model/cloud-runner/options/cloud-runner-options.ts 90.16% <100.00%> (ø)
src/model/cloud-runner/providers/aws/index.ts 15.15% <ø> (ø)
src/model/cloud-runner/providers/docker/index.ts 16.36% <ø> (ø)
src/model/cloud-runner/providers/local/index.ts 16.66% <ø> (ø)
src/model/cloud-runner/providers/test/index.ts 11.11% <ø> (ø)
src/model/cloud-runner/remote-client/caching.ts 14.28% <ø> (ø)
...-runner/services/core/task-parameter-serializer.ts 74.35% <ø> (-0.33%) ⬇️
...ud-runner/services/hooks/container-hook-service.ts 72.28% <ø> (+2.97%) ⬆️
src/model/input.ts 88.43% <100.00%> (ø)
src/model/cloud-runner/error/cloud-runner-error.ts 44.44% <0.00%> (ø)
... and 16 more

... and 20 files with indirect coverage changes

@frostebite frostebite force-pushed the cloud-runner-develop branch from 22d282c to e580bee Compare March 30, 2023 21:48
@frostebite frostebite marked this pull request as ready for review March 31, 2023 11:53
Copy link
Member

@webbertakken webbertakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to review something if it doesn't have a description, especially if you have more than 2 or 3 files changed.

It's also hard to figure out what multiple PRs do or look for a specific change if none of the PRs have a description.

Let's follow best practices where possible.

.github/workflows/cloud-runner-ci-pipeline.yml Outdated Show resolved Hide resolved
src/model/cloud-runner/cloud-runner.ts Show resolved Hide resolved
src/model/github.ts Outdated Show resolved Hide resolved
@frostebite frostebite marked this pull request as draft May 10, 2023 03:00
@frostebite frostebite marked this pull request as ready for review January 30, 2024 22:59
@frostebite frostebite removed the request for review from AndrewKahr January 30, 2024 23:02
@frostebite frostebite marked this pull request as draft January 30, 2024 23:57
@frostebite frostebite marked this pull request as ready for review January 31, 2024 00:29
@frostebite
Copy link
Member Author

It's hard to review something if it doesn't have a description, especially if you have more than 2 or 3 files changed.

It's also hard to figure out what multiple PRs do or look for a specific change if none of the PRs have a description.

Let's follow best practices where possible.

If it were easy to break into a few changes I would. In this case I stabilize the k8s provider so I think it's needed to stabilise main.

I will avoid making such big MRs generally. But getting k8s from a prototype to generally usable was a lot of changes.

@frostebite frostebite merged commit e73b48f into main Feb 6, 2024
63 of 81 checks passed
@frostebite frostebite deleted the cloud-runner-develop branch February 6, 2024 23:46
simon-homa pushed a commit to homagames/unity-builder that referenced this pull request Mar 7, 2024
* fixes

* fixes

* fixes

* fixes

* fixes

* check for startup message in workflows

* check for startup message in workflows

* check for startup message in workflows

* check for startup message in workflows

* check for startup message in workflows

* check for startup message in workflows

* Update cloud-runner-ci-pipeline.yml

* Update cloud-runner-ci-pipeline.yml

* no storage class specified

* log file path

* log file path

* log file path

* log file path

* log file path

* log file path

* log file path

* log file path

* updates

* log file path

* latest develop

* log file path

* log file path

* Update package.json

* log file path

* log file path

* log file path

* log file path

* log file path

* log file path

* log file path

* log file path

* log file path

* log file path

* log file path

* log file path

* log file path

* log file path

* stream logs through standard input and new remote client cli command

* stream logs through standard input and new remote client cli command

* stream logs through standard input and new remote client cli command

* stream logs through standard input and new remote client cli command

* stream logs through standard input and new remote client cli command

* stream logs through standard input and new remote client cli command

* stream logs through standard input and new remote client cli command

* stream logs through standard input and new remote client cli command

* stream logs through standard input and new remote client cli command

* stream logs through standard input and new remote client cli command

* stream logs through standard input and new remote client cli command

* stream logs through standard input and new remote client cli command

* stream logs through standard input and new remote client cli command

* stream logs through standard input and new remote client cli command

* stream logs through standard input and new remote client cli command

* update pipeline to use k3s

* version: 'latest'

* fixes

* disable aws pipe for now

* disable aws pipe for now

* disable aws pipe for now

* disable aws pipe for now

* disable aws pipe for now

* disable aws pipe for now

* disable aws pipe for now

* disable aws pipe for now

* disable aws pipe for now

* disable aws pipe for now

* push k8s logs to LOG SERVICE IP

* push k8s logs to LOG SERVICE IP

* push k8s logs to LOG SERVICE IP

* push k8s logs to LOG SERVICE IP

* push k8s logs to LOG SERVICE IP

* push k8s logs to LOG SERVICE IP

* push k8s logs to LOG SERVICE IP

* push k8s logs to LOG SERVICE IP

* tests

* tests

* tests

* tests

* tests

* tests

* tests

* tests

* tests

* tests

* tests

* tests

* tests

* tests

* tests

* tests

* tests

* podname logs for log service

* podname logs for log service

* podname logs for log service

* podname logs for log service

* podname logs for log service

* podname logs for log service

* podname logs for log service

* podname logs for log service

* podname logs for log service

* hashed logs

* hashed logs

* hashed logs

* hashed logs

* hashed logs

* hashed logs

* no wait, just repeat logs

* no wait, just repeat logs

* remove typo - double await

* test fix - kubernetes - name typo in github yaml

* test fix - kubernetes - name typo in github yaml

* check missing log file

* check missing log file

* Push to steam test

* Push to steam test

* Fix path

* k8s reliable log hashing

* k8s reliable log hashing

* k8s reliable log hashing

* hashed logging k8s

* hashed logging k8s

* hashed logging k8s

* hashed logging k8s

* hashed logging k8s

* hashed logging k8s

* Include log chunk when task runner sees log update, clarify if we can pull logs from same line or next line

* Include log chunk when task runner sees log update, clarify if we can pull logs from same line or next line

* Include log chunk when task runner sees log update, clarify if we can pull logs from same line or next line

* Include log chunk when task runner sees log update, clarify if we can pull logs from same line or next line

* Include log chunk when task runner sees log update, clarify if we can pull logs from same line or next line

* Fix exit flow for k8s job

* hash comparison logging for log complete in k8s flow

* Interrupt k8s logs when logs found

* cleanup async parameter

* cleanup async parameter

* cleanup async parameter

* fixes

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants