Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ENA_Biodiv_submission Tutorial #5117

Merged
merged 60 commits into from
Dec 13, 2024

Conversation

Najatamk
Copy link
Contributor

@Najatamk Najatamk commented Jul 3, 2024

No description provided.

@yvanlebras yvanlebras requested review from yvanlebras and removed request for yvanlebras July 4, 2024 07:51
yvanlebras
yvanlebras previously approved these changes Dec 6, 2024
Copy link
Member

@shiltemann shiltemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @yvanlebras! A bit more text between the boxes would be nice, and a few final comments below.

@yvanlebras
Copy link
Collaborator

Is it ok for you @shiltemann ? THANK YOU so much for your help!

@shiltemann
Copy link
Member

Thanks @yvanlebras! Looks good to me, just two final remarks/questions above, and then let's merge!

yvanlebras and others added 2 commits December 13, 2024 14:08
@yvanlebras
Copy link
Collaborator

Seems to be ok for me! THNAK YOU so much @shiltemann ! Hope all is ok on your side!

@shiltemann
Copy link
Member

@yvanlebras I've updated some more hands-on boxes, pleases double check that it is ok for you.

In the future, I can recommend creating a tutorial skeleton from the workflow, then the box formatting is all done for you!

@shiltemann shiltemann enabled auto-merge December 13, 2024 15:46
@shiltemann shiltemann disabled auto-merge December 13, 2024 15:46
@shiltemann
Copy link
Member

I've approved it, feel free to merge if it is good for you (and tests pass)

@shiltemann
Copy link
Member

Thanks a lot @Najatamk @yvanlebras!

@shiltemann
Copy link
Member

oh hang on, could you add the workflow file to the workflows folder?

@yvanlebras yvanlebras merged commit a7709f1 into galaxyproject:main Dec 13, 2024
3 checks passed
@bgruening
Copy link
Member

oh hang on, could you add the workflow file to the workflows folder?

ping @yvanlebras

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants