Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ocean variables tuto #4849

Merged
merged 23 commits into from
Mar 25, 2024
Merged

Update ocean variables tuto #4849

merged 23 commits into from
Mar 25, 2024

Conversation

Marie59
Copy link
Contributor

@Marie59 Marie59 commented Mar 19, 2024

Update of Ocean variables tuto. 1 workflow added with 2 tools following the first ODV tool. Plus, it matches the recent update made on ODV and divand tools.

As usual, no test ;)

  1. Give your pull request a good title
    • e.g. "Fix typo in ansible-galaxy tutorial" or "Add new transcriptomics tutorial covering a new sequencing technology"
  2. Describe your changes in detail, list anything you still need some help with or things that are still TODO
  3. Check that your images are allowed to be re-hosted by the GTN!
  4. Still working on it? Make it a Draft pull request
    • Once it is ready, choose Ready for Review
    • Then the automated tests will run and we will know to review and merge it

@Marie59
Copy link
Contributor Author

Marie59 commented Mar 19, 2024

I think that except for the missing test all checks passed !:)

topics/climate/tutorials/ocean-variables/tutorial.md Outdated Show resolved Hide resolved
topics/climate/tutorials/ocean-variables/tutorial.md Outdated Show resolved Hide resolved
topics/climate/tutorials/ocean-variables/tutorial.md Outdated Show resolved Hide resolved
@@ -96,7 +91,7 @@ Once you finish your work on ODV, if you want to retrieve data and/or the entire
> - *"Select if you are using an ODV collection in a zip folder or if you have your own raw data"*: `The data you are using are an ODV collection in a zip folder`
> - *"ODV collection in a zip folder."*: `Eutrophication_Med_profiles_2022_unrestricted_SNAPSHOT_2023-10-24T16-39-44.zip`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does this file come from? Is it in a zenodo somewhere or ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh forgot that ! I will put it on github (not the best hopefuuly it's temporary and i'll update the tutorial when needed)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depending on the size, zenodo is also good! (We try and avoid having too-large files in the GTN where possible.)

Copy link
Contributor Author

@Marie59 Marie59 Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's big but I loaded it in the Fair-Ease github

@hexylena
Copy link
Member

workflow tests should now pass as well :)

@Marie59
Copy link
Contributor Author

Marie59 commented Mar 22, 2024

I on myself have nothing else to add for this tuto. Do you think we can merge it or do it need some more review ? Are the data like that on github good ?

@bgruening bgruening merged commit b904f50 into galaxyproject:main Mar 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants