-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ocean variables tuto #4849
Conversation
I think that except for the missing test all checks passed !:) |
@@ -96,7 +91,7 @@ Once you finish your work on ODV, if you want to retrieve data and/or the entire | |||
> - *"Select if you are using an ODV collection in a zip folder or if you have your own raw data"*: `The data you are using are an ODV collection in a zip folder` | |||
> - *"ODV collection in a zip folder."*: `Eutrophication_Med_profiles_2022_unrestricted_SNAPSHOT_2023-10-24T16-39-44.zip` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where does this file come from? Is it in a zenodo somewhere or ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh forgot that ! I will put it on github (not the best hopefuuly it's temporary and i'll update the tutorial when needed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depending on the size, zenodo is also good! (We try and avoid having too-large files in the GTN where possible.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's big but I loaded it in the Fair-Ease github
workflow tests should now pass as well :) |
Co-authored-by: Helena <hexylena@galaxians.org>
Co-authored-by: Helena <hexylena@galaxians.org>
I on myself have nothing else to add for this tuto. Do you think we can merge it or do it need some more review ? Are the data like that on github good ? |
Update of Ocean variables tuto. 1 workflow added with 2 tools following the first ODV tool. Plus, it matches the recent update made on ODV and divand tools.
As usual, no test ;)