Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update pathway analysis tutorial #4486

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tduigou
Copy link

@tduigou tduigou commented Nov 5, 2023

Update documentation, labels, workflow and version of tools for the Pathway Analysis tutorial.

@@ -112,7 +112,7 @@ We first perform an FBA (with COBRApy) optimizing the biomass reaction and recor

> <hands-on-title>Calculating the flux of a target using Flux Balance Analysis (FBA)</hands-on-title>
>
> 1. Run {% tool [Flux balance analysis](toolshed.g2.bx.psu.edu/repos/iuc/rpfba/rpfba/5.12.1) %} with the following parameters:
> 1. Run {% tool [Flux balance analysis](toolshed.g2.bx.psu.edu/repos/tduigou/rptools_rpfba/rptools_rpfba/6.3.2+galaxy0) %} with the following parameters:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you maybe add your changes back to the IUC tool? That way we don't break the tool linage and don't need to update all Galaxy servers.

I pull request to this repo would be great: https://github.com/galaxyproject/tools-iuc
I will help you to get the changes in if you like.

@hexylena hexylena marked this pull request as draft December 5, 2023 14:45
@hexylena
Copy link
Member

hexylena commented Dec 5, 2023

Converting to draft, pending requested changes

@tduigou
Copy link
Author

tduigou commented Dec 12, 2023

Hello @bgruening, I added additional changes regarding (i) new version of tools used in for the RetroSynthesis and the Pathway Analysis tutorials (previous versions were bugged), (ii) update of the workflows associated.

Regarding the change from iuc to the tduigou channel, all the other tools are using the tduigou channel. We think it would be more consistent if rpfba / rptools_rpfba tool would be referenced to this channel as well.

@shiltemann
Copy link
Member

@tduigou a big reason to put the tools into the IUC, is that the 3 large Galaxies will be much more likely to install the tools (because they have some confidence in the quality without having to examine the code of each tool themselves). So we strongly encourage tutorial authors to do this wherever possible. Plus, you get the free help maintaining the wrappers and always keeping them compatible with the latest Galaxy version :) So I would strongly encourage you to add all the tools to IUC. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants