Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated 2 workflows and tutorials to use the latest version of Galaxy-ML #4428

Merged
merged 11 commits into from
Oct 17, 2023

Conversation

kxk302
Copy link
Collaborator

@kxk302 kxk302 commented Oct 13, 2023

Thank you for contributing to the GTN! 💛

Please check that:

  • Your pull request has a good title, e.g.
    • "Fix typo in ansible-galaxy tutorial"
    • "Add new transcriptomics tutorial covering a new sequencing technology"
  • Please replace this entire pull request message with a description of your changes, it will help us review your pull request faster
  • Check that your images are allowed to be re-hosted by the GTN

Once these are done, you're ready to go!

Consider sustainable computing with Draft Mode 💚

Is your pull request finished? 100% ready to be merged? Or do you want some time to work on it first (which we encourage! It's great to have visibility)

If not, then please consider creating this pull request as a draft.

Regular pull requests will trigger automated test runs when they are created
and every time you update them.

As a small contribution to sustainable computing, we skip the most energy intensive of these tests for pull requests marked as drafts. Once your pull request is ready to go, then you can click a button saying "Ready for Review" and the tests will be run!

@kxk302 kxk302 requested a review from a team as a code owner October 13, 2023 18:31
@kxk302
Copy link
Collaborator Author

kxk302 commented Oct 13, 2023

Hi @anuprulez,
I updated 2 workflows/tutorials and created this PR. When you get a chance, could you please take a look?
Thanks!

@bgruening
Copy link
Member

@kxk302 are you up to generating a workflow test for this one?

@kxk302
Copy link
Collaborator Author

kxk302 commented Oct 13, 2023

@kxk302 are you up to generating a workflow test for this one?

@bgruening Sure! Is there a code snippet I could refer to? Thanks

@bgruening
Copy link
Member

This here might help: https://training.galaxyproject.org/training-material/faqs/gtn/gtn_workflow_testing.html

@@ -0,0 +1,368 @@
{
"a_galaxy_workflow": "true",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi there are more lintung errors which you'll find in the Files tab of GitHub. Thanks for fixing them!

@kxk302
Copy link
Collaborator Author

kxk302 commented Oct 17, 2023

Seems all the checks have passed. Ready for review!

Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for fixing all the linting complaints @kxk302 !

@hexylena hexylena merged commit 373c662 into galaxyproject:main Oct 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants