Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of User-Reported Dataset Error Emails #19401

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

hujambo-dunia
Copy link
Contributor

@hujambo-dunia hujambo-dunia commented Jan 13, 2025

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs
Copy link
Member

jdavcs commented Jan 13, 2025

Can you, please, reword the commit description as per our guidelines (https://github.com/galaxyproject/galaxy/blob/dev/CONTRIBUTING.md#how-to-contribute, item 6) - i.e., short imperative sentence, then space, followed by detailed description when needed). It really matters for working with git history and for release notes.

@hujambo-dunia hujambo-dunia force-pushed the user-reporting-err-component branch 2 times, most recently from d5c8c36 to e86ee81 Compare January 15, 2025 20:12
Make component reusable, changes made:
* Componentized email web form into Vue.js
* Decoupled the View (html email) from the Controller (API methods)
* Abstracted the View elements for reuse with other objects (eg.Tools)
* Utilized existing dependency (Python Jinja2) for repo consistency

Reported by @hexylena in issue
galaxyproject#17560 .
@hujambo-dunia hujambo-dunia force-pushed the user-reporting-err-component branch from 5363c23 to 922a3fa Compare January 16, 2025 17:03
@hujambo-dunia hujambo-dunia marked this pull request as ready for review January 16, 2025 20:32
@github-actions github-actions bot added this to the 25.0 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants