Add tags to output datasets from tool form #19225
Open
+31
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/UI-UX
area/database
|
@itisAliRH Can you have a look? |
Co-authored-by: PlushZ <polpolunina@gmail.com>
Changes the value prop to accept an array of strings instead of a comma-separated string Sets default values for props using withDefaults Simplifies the onInput function to emit an array directly Co-authored-by: PlushZ <polpolunina@gmail.com>
Replaces the tags input section with a FormElement component with tags type for consistency. Removes the StatelessTags component and its import. Improves UI consistency and code maintainability. Co-authored-by: PlushZ <polpolunina@gmail.com>
|
@PlushZ thank you for your work on this. As we discussed, I made the changes, which look good. |
Moves tag extraction to ensure tags are correctly set during tool execution. This change ensures that tags are consistently retrieved from incoming parameters and applied to the request context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces functionality to let users add tags to output datasets directly from the Tool Form in Galaxy. The tags are captured in the frontend, passed to the backend during job submission, and associated with the appropriate output datasets upon job completion.
UI:
Tags Section:
Option 1 (current code version): A static "Add tags" section is displayed above the "Run Tool" button. The tag functionality is powered by
StatelessTags.vue, which allows users to add and manage tags dynamically.Flow:
Option 2: A collapsible dropdown toggle button is introduced to optionally show or hide the tags section. This alternative implementation uses
Tag.vuefor tag functionality.Flow:
Job submission:
Backend:
Issues to be solved with this PR: #8710, #13885
How to test the changes?
(Select all options that apply)
License