[24.1] Fix export_remote include/exclude metadata flag

[davelopez]

Fixes #18564

We were passing 'false' to --export-metadata-files, but it was considered True (non-zero length string), and the metadata was always included in the export.

How to test the changes?

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  • Follow the steps in Export Data tool - bai files exported despite export-metadata-files is set as No #18564

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[davelopez]

Should I target an older branch?

[mvdbeek]

I think 24.1 would be fine ? This is so niche that no-one ran into this before, and as you can see those old tests are a mess.

We were passing 'false' to --export-metadata-files, but it was considered True (non-zero length string)

Are you saying type=bool acts as a flag ? In that case I think the slightly better fix is

diff --git a/tools/data_export/export_remote.xml b/tools/data_export/export_remote.xml
index ef5450cc55..77d72802ed 100644
--- a/tools/data_export/export_remote.xml
+++ b/tools/data_export/export_remote.xml
@@ -10,7 +10,9 @@ python '$__tool_directory__/export_remote.py'
     --file-sources '$file_sources'
     --directory-uri '$d_uri'
     --files-to-export '$files_to_export'
-    --export-metadata-files $include_metadata_files
+#if $include_metadata_files:
+    --export-metadata-files
+#end if
     > '$out'
     ]]></command>
     <configfiles>