Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Revert unnecessary error change #17948

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Apr 9, 2024

Upgrade messages are collected via step.upgrade_messages. Addresses https://github.com/galaxyproject/galaxy/pull/17858/files#r1557810107

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Upgrade messages are collected via step.upgrade_messages.
Addresses https://github.com/galaxyproject/galaxy/pull/17858/files#r1557810107
@mvdbeek mvdbeek requested a review from nsoranzo April 9, 2024 15:51
@github-actions github-actions bot added this to the 24.1 milestone Apr 9, 2024
@nsoranzo
Copy link
Member

nsoranzo commented Apr 9, 2024

Is the content of step.upgrade_messages included somewhere in the dict returned by _workflow_to_dict_export() (if that was the intention)?

@mvdbeek
Copy link
Member Author

mvdbeek commented Apr 9, 2024

It is in the various export flavors, but not systematically.

@jdavcs jdavcs removed this from the 24.1 milestone Apr 10, 2024
@jdavcs jdavcs merged commit 6700809 into galaxyproject:release_24.0 Apr 10, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants