Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.0] Fix output datatype when uncompressing a dataset with incorrect datatype #17944

Merged

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Apr 9, 2024

with the CONVERTER_gz_to_uncompressed tool.

Previously, if a user forced an incorrect datatype to a compressed input dataset (e.g. fastqsanger instead of fastqsanger.gz), then the output datatype assigned by this tool would be an invalid one (fastqsan).

Fix #17938.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

with the ``CONVERTER_gz_to_uncompressed`` tool.

Previously, if a user forced an incorrect datatype to a compressed input
dataset (e.g. `fastqsanger` instead of `fastqsanger.gz`), then the output
datatype assigned by this tool would be an invalid one (`fastqsan`).

Fix galaxyproject#17938.
@nsoranzo nsoranzo requested a review from mvdbeek April 9, 2024 11:19
@github-actions github-actions bot added this to the 23.0 milestone Apr 9, 2024
@mvdbeek mvdbeek merged commit 3abb181 into galaxyproject:release_23.0 Apr 9, 2024
25 of 35 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Apr 9, 2024

Thanks a lot @nsoranzo!

@nsoranzo nsoranzo deleted the release_23.0_fix_17938 branch April 9, 2024 13:40
@nsoranzo nsoranzo changed the title [23.] Fix output datatype when uncompressing a dataset with incorrect datatype [23.0] Fix output datatype when uncompressing a dataset with incorrect datatype Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants