WIP (wait for sqlalchemy2-stubs): Added types to lib/galaxy/model/__init__.py #12971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 tasks
dakariakin
force-pushed
the
add-types-to-model
branch
from
8602bae to
a56dbaf
Compare
mvdbeek
reviewed
Nov 24, 2021
Comment on lines
+332
to
+333
| update_time: datetime | ||
| create_time: datetime |
There was a problem hiding this comment.
That'll conflict with the types defined by the sqlalchemy models
| @@ -309,6 +316,7 @@ def _serialize(self, id_encoder: IdEncodingHelper, serialization_options: Serial | |||
|
|
|||
|
|
|||
| class HasName: | |||
| name: str | |||
There was a problem hiding this comment.
That'll conflict with the types defined by the sqlalchemy models
Comment on lines
+389
to
+390
| id: int | ||
| tool_id: int |
There was a problem hiding this comment.
That'll conflict with the types defined by the sqlalchemy models
dakariakin
changed the title
|
@mvdbeek Thank you, that makes sense. I'll update this PR after sqlalchemy2-stubs installed |
|
The original issue is closed common-workflow-lab#137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: common-workflow-lab#137
What: Improved type hints
How to test the changes?
(Select all options that apply)
License