Type updates #12868
Merged
Type updates #12868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-c
force-pushed
the
type_updates
branch
5 times, most recently
from
fb42185 to
dae7318
Compare
mr-c
commented
Nov 10, 2021
| disallow_untyped_decorators = True | ||
| no_implicit_optional = True | ||
| warn_unused_ignores = True | ||
| warn_return_any = True |
There was a problem hiding this comment.
If warn_return_any = True is specified under [mypy-galaxy.tools.wrappers] then tox -e test_galaxy_packages fails
mypy galaxy tests
galaxy/tools/wrappers.py:262: error: Returning Any from function declared to return "Iterator[Any]"
galaxy/tools/wrappers.py:265: error: Returning Any from function declared to return "bool"
galaxy/tools/wrappers.py:346: error: Returning Any from function declared to return "List[Tuple[str, str]]"
galaxy/tools/wrappers.py:365: error: Returning Any from function declared to return "bool"
galaxy/tools/wrappers.py:573: error: Returning Any from function declared to return "List[List[Any]]"
but tox -e py36-mypy passes
davelopez
reviewed
Nov 10, 2021
mr-c
force-pushed
the
type_updates
branch
2 times, most recently
from
bdc5fc8 to
14df18a
Compare
mr-c
commented
Nov 10, 2021
mr-c
commented
Nov 10, 2021
jmchilton
reviewed
Nov 10, 2021
3 tasks
lib/galaxy/workflow/run.py:333: error: Item "DatasetCollection" of "Union[HistoryDatasetCollectionAssociation, DatasetCollection]" has no attribute "collection"
The code wouldn't currently work if `replacement` is a `DatasetCollection` because it tries to access the `collection` attribute which is available only for `HistoryDatasetCollectionAssociation`.
nsoranzo
reviewed
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: common-workflow-lab#137
What: Improved type hints
How to test the changes?
(Select all options that apply)
License