thank you test_galaxy_packages

galaxyproject · Nov 12, 2021 · b93b3f3 · b93b3f3
1 parent f148442
commit b93b3f3
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/galaxy/tools/__init__.py b/lib/galaxy/tools/__init__.py
@@ -664,6 +664,8 @@ def _view(self):
 
     @property
     def version_object(self):
+        if self.version is None:
+            raise Exception("Must call parse() first")
         return packaging.version.parse(self.version)
 
     @property
@@ -2604,7 +2606,7 @@ def exec_before_job(self, app, inp_data, out_data, param_dict=None):
             json_params['output_data'].append(data_dict)
             if json_filename is None:
                 json_filename = file_name
-        if not json_filename:
+        if json_filename is None:
             raise Exception(
                 "Must call 'exec_before_job' with 'out_data' containing at least one entry."
             )
@@ -2759,7 +2761,7 @@ def exec_before_job(self, app, inp_data, out_data, param_dict=None):
             json_params['output_data'].append(data_dict)
             if json_filename is None:
                 json_filename = file_name
-        if not json_filename:
+        if json_filename is None:
             raise Exception(
                 "Must call 'exec_before_job' with 'out_data' containing at least one entry."
             )