-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nuclear star cluster component #779
base: master
Are you sure you want to change the base?
Conversation
This is a Mac OS config file and should not be included in Galacticus.
Such files should never be added.
Adding comments from Matias here for reference:
and not related to my projects, I think there is a mistake in the |
Yes - definitely a mistake. I opened issue #781 for this and will push a fix. |
This seems reasonable. I'd suggest making it some fraction of the NSC stellar mass. |
I caught this problem in the PR refactoring black hole physics, and it is now implemented correctly there. We'll need to be sure to move the equivalent NSC behavior to this new class (after I merge in that PR). |
It would be better to move this to the |
* Renames files for consistency; * Conventionalizes citations; * Adds a glossary entry for nuclear star cluster (NSC); * Renames variables for clarity; * Reformats code for clarity.
* Variable renaming for clarity.
* Rename variables for clarity.
Add nuclear star cluster model and BH seed formation scenario within NSCs due to stellar collisions.