Set platform release branch #2500
Conversation
WalkthroughThe pull request modifies the GitHub Actions workflow file Changes
Possibly related PRs
Suggested reviewers
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: e2e (22.x)
- GitHub Check: build (22.x, windows-latest)
- GitHub Check: codecov
🔇 Additional comments (1)
.github/workflows/release.yml (1)
Line range hint
110-134: Test this version change in a staging environment first.This is a critical change in the release workflow that affects the bundling of multiple components. Before merging:
- Test the workflow with this version in a staging environment
- Verify that all components are bundled correctly
- Validate the output bundle structure and contents
- Ensure compatibility with the CDN sync process
Run this script to compare the bundle output between versions:
| @@ -107,7 +107,7 @@ jobs: | |||
| cat ${{ github.workspace }}/platform-adapter/package.json | |||
|
|
|||
| - name: Bundle polyfill and engine | |||
| uses: galacean/platform-adapter@main | |||
| uses: galacean/platform-adapter@0.0 | |||
There was a problem hiding this comment.
💡 Codebase verification
🛠️ Refactor suggestion
Use specific alpha version instead of partial version specifier
The repository only has alpha releases (v0.0.0-alpha.1 through v0.0.0-alpha.9). Using @0.0 with pre-release software could lead to unexpected behavior. Consider using the latest specific version: @v0.0.0-alpha.9
🔗 Analysis chain
Verify the platform adapter version choice.
While pinning the version is a good practice for stability and reproducibility, @0.0 seems unusual. This version number might indicate a pre-release version or could be incorrect.
Let's verify the available versions:
Consider using:
- A specific release version (e.g.,
@1.0.0) for stability - A specific commit SHA for immutability
- A major version tag (e.g.,
@v1) for managed updates within major versions
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check available versions of the platform-adapter action
# Check the repository's releases and tags
gh api repos/galacean/platform-adapter/releases --jq '.[].tag_name'
gh api repos/galacean/platform-adapter/tags --jq '.[].name'
Length of output: 296
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/1.4 #2500 +/- ##
===========================================
- Coverage 68.50% 68.49% -0.01%
===========================================
Files 956 956
Lines 100007 100007
Branches 8545 8545
===========================================
- Hits 68506 68497 -9
- Misses 31245 31254 +9
Partials 256 256
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit