Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor AST code in ShaderLab for performance #2486
base: main
Are you sure you want to change the base?
Refactor AST code in ShaderLab for performance #2486
Changes from 9 commits
e348595
6c99773
bc17b5e
b80c07d
fa943f7
5d82a2e
10c3099
cd687f8
53fdfea
3c32195
1383dd9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 21 in e2e/case/material-shaderLab.ts
e2e/case/material-shaderLab.ts#L21
Check warning on line 6 in e2e/case/project-loader.ts
e2e/case/project-loader.ts#L6
Check warning on line 8 in e2e/case/project-loader.ts
e2e/case/project-loader.ts#L8
Check warning on line 15 in e2e/case/project-loader.ts
e2e/case/project-loader.ts#L15
Check warning on line 22 in e2e/case/project-loader.ts
e2e/case/project-loader.ts#L21-L22
Check warning on line 28 in e2e/case/project-loader.ts
e2e/case/project-loader.ts#L25-L28
Check warning on line 7 in e2e/case/shaderLab-mrt.ts
e2e/case/shaderLab-mrt.ts#L7
Check warning on line 19 in e2e/case/shaderLab-renderState.ts
e2e/case/shaderLab-renderState.ts#L19
Check warning on line 24 in examples/buffer-mesh-particle-shader-effect.ts
examples/buffer-mesh-particle-shader-effect.ts#L22-L24
Check warning on line 100 in examples/buffer-mesh-particle-shader-effect.ts
examples/buffer-mesh-particle-shader-effect.ts#L100
Check warning on line 104 in examples/buffer-mesh-particle-shader-effect.ts
examples/buffer-mesh-particle-shader-effect.ts#L104
Check warning on line 108 in examples/buffer-mesh-particle-shader-effect.ts
examples/buffer-mesh-particle-shader-effect.ts#L108
Check warning on line 112 in examples/buffer-mesh-particle-shader-effect.ts
examples/buffer-mesh-particle-shader-effect.ts#L112
Check warning on line 116 in examples/buffer-mesh-particle-shader-effect.ts
examples/buffer-mesh-particle-shader-effect.ts#L116
Check warning on line 120 in examples/buffer-mesh-particle-shader-effect.ts
examples/buffer-mesh-particle-shader-effect.ts#L120
Check warning on line 128 in examples/buffer-mesh-particle-shader-effect.ts
examples/buffer-mesh-particle-shader-effect.ts#L128
Check warning on line 233 in examples/buffer-mesh-particle-shader-effect.ts
examples/buffer-mesh-particle-shader-effect.ts#L233
Check warning on line 239 in examples/buffer-mesh-particle-shader-effect.ts
examples/buffer-mesh-particle-shader-effect.ts#L237-L239
Check warning on line 246 in examples/buffer-mesh-particle-shader-effect.ts
examples/buffer-mesh-particle-shader-effect.ts#L246
Check warning on line 253 in examples/buffer-mesh-particle-shader-effect.ts
examples/buffer-mesh-particle-shader-effect.ts#L253
Check warning on line 261 in examples/buffer-mesh-particle-shader-effect.ts
examples/buffer-mesh-particle-shader-effect.ts#L260-L261
Check warning on line 264 in examples/buffer-mesh-particle-shader-effect.ts
examples/buffer-mesh-particle-shader-effect.ts#L264
Check warning on line 23 in examples/shader-lab-multi-pass.ts
examples/shader-lab-multi-pass.ts#L23
Check warning on line 8 in examples/shader-lab-simple.ts
examples/shader-lab-simple.ts#L7-L8
Check warning on line 24 in examples/shader-lab-simple.ts
examples/shader-lab-simple.ts#L23-L24
Check warning on line 112 in examples/shader-lab-simple.ts
examples/shader-lab-simple.ts#L111-L112
Check warning on line 114 in examples/shader-lab-simple.ts
examples/shader-lab-simple.ts#L114
Check warning on line 120 in examples/shader-lab-simple.ts
examples/shader-lab-simple.ts#L120
Check warning on line 125 in examples/shader-lab-simple.ts
examples/shader-lab-simple.ts#L125
Check warning on line 132 in examples/shader-lab-simple.ts
examples/shader-lab-simple.ts#L132
Check warning on line 138 in examples/shader-lab-simple.ts
examples/shader-lab-simple.ts#L138
Check warning on line 143 in examples/shader-lab-simple.ts
examples/shader-lab-simple.ts#L143
Check warning on line 149 in examples/shader-lab-simple.ts
examples/shader-lab-simple.ts#L149
Check warning on line 154 in examples/shader-lab-simple.ts
examples/shader-lab-simple.ts#L153-L154
Check warning on line 24 in examples/shader-lab.ts
examples/shader-lab.ts#L22-L24
Check warning on line 30 in examples/shader-lab.ts
examples/shader-lab.ts#L30
Check warning on line 36 in examples/shader-lab.ts
examples/shader-lab.ts#L36
Check warning on line 41 in examples/shader-lab.ts
examples/shader-lab.ts#L41
Check warning on line 46 in examples/shader-lab.ts
examples/shader-lab.ts#L46
Check warning on line 63 in examples/shader-lab.ts
examples/shader-lab.ts#L63
Check warning on line 75 in examples/shader-lab.ts
examples/shader-lab.ts#L75
Check warning on line 86 in examples/shader-lab.ts
examples/shader-lab.ts#L83-L86
Check warning on line 92 in examples/shader-lab.ts
examples/shader-lab.ts#L92
Check warning on line 98 in examples/shader-lab.ts
examples/shader-lab.ts#L98