Skip to content

Commit

Permalink
documenation matching to functions and reinstate vignette building
Browse files Browse the repository at this point in the history
  • Loading branch information
Drew Behrens committed Feb 7, 2024
1 parent fa5ce9c commit 2811236
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/check-bioc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ jobs:
## This pass does not use AnVIL and will thus update any packages
## that have seen been updated in Bioconductor
message(paste('****', Sys.time(), 'pass number 2 at installing dependencies: any remaining dependencies ****'))
remotes::install_local(dependencies = TRUE, repos = BiocManager::repositories(), build_vignettes = FALSE, upgrade = TRUE, force = TRUE)
remotes::install_local(dependencies = TRUE, repos = BiocManager::repositories(), build_vignettes = TRUE, upgrade = TRUE, force = TRUE)
shell: Rscript {0}

- name: Install BiocGenerics
Expand Down Expand Up @@ -248,7 +248,7 @@ jobs:
options(crayon.enabled = TRUE)
rcmdcheck::rcmdcheck(
args = c("--no-manual", "--no-vignettes", "--timings"),
build_args = c("--no-build-vignettes", "--no-manual", "--keep-empty-dirs", "--no-resave-data"),
build_args = c("--no-manual", "--keep-empty-dirs", "--no-resave-data"),
error_on = "warning",
check_dir = "check"
)
Expand Down
12 changes: 6 additions & 6 deletions R/AllGenerics.R
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ asFDS <- function(x){
#' mcols(fds, type="psi5")
#' mcols(fds, type="theta")
#' seqlevels(fds)
#' seqlevels(mapSeqlevels(fds, style="UCSC", drop=FALSE))
#' seqlevels(mapSeqlevels(fds, style="Ensembl", drop=FALSE))
#' seqlevels(mapSeqlevels(fds, style="dbSNP", drop=FALSE))
#' seqlevels(mapSeqlevels(fds, style="UCSC"))
#' seqlevels(mapSeqlevels(fds, style="Ensembl"))
#' seqlevels(mapSeqlevels(fds, style="dbSNP"))
#'
#' @author Christian Mertes \email{mertes@@in.tum.de}
#' @author Ines Scheller \email{scheller@@in.tum.de}
Expand Down Expand Up @@ -232,7 +232,7 @@ setReplaceMethod("nonSplicedReads", "FraserDataSet", function(object, value){
#' @param j A integer vector to subset the columns/samples
#' @param by a character (j or ss) defining if we subset by
#' junctions or splice sites
#' @param dropBool Currently not used
#' @param drop Currently not used
#' @return A subsetted \code{FraserDataSet} object
#' @examples
#' fds <- createTestFraserDataSet()
Expand Down Expand Up @@ -851,9 +851,9 @@ resultsByGenes <- function(res, geneColumn="hgncSymbol", method="BY"){
#'
#' @rdname fds-methods
#' @export
mapSeqlevels <- function(fds, style="UCSC", ..., drop=FALSE){
mapSeqlevels <- function(fds, style="UCSC", ...){

mappings <- na.omit(GenomeInfoDb::mapSeqlevels(seqlevels(fds), style, ..., drop=FALSE))
mappings <- na.omit(GenomeInfoDb::mapSeqlevels(seqlevels(fds), style, ...))
# fix missing names() when fds has only a single chromosome
if(is.null(names(mappings))){
names(mappings) <- seqlevels(fds)
Expand Down
6 changes: 3 additions & 3 deletions man/fds-methods.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2811236

Please sign in to comment.