Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logLevel to not touch simple-logger defaultLogLevel #368

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gabrielfeo
Copy link
Owner

Fix #331

Config.logLevel / DEVELOCITY_API_LOG_LEVEL internally changes org.slf4j.simpleLogger.defaultLogLevel, which changes level of all loggers, not only the library's as the javadoc says. In practice, this is an issue when the user is using simple-logger and using loggers (or using other dependencies that use loggers), as changing Config.logLevel / DEVELOCITY_API_LOG_LEVEL will unexpectedly affect those loggers.

Copy link
Contributor

Job Summary for Gradle

Check PR :: kotlin-tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
develocity-api-kotlin
test compileIntegrationTestKotlin :build-logic:check :libra…
8.12 Build Scan published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config.logLevel / DEVELOCITY_API_LOG_LEVEL should only affect library's loggers
1 participant