Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created dockerconfigjson isn't correct #24

Open
Vad1mo opened this issue Mar 27, 2020 · 3 comments
Open

created dockerconfigjson isn't correct #24

Vad1mo opened this issue Mar 27, 2020 · 3 comments

Comments

@Vad1mo
Copy link

Vad1mo commented Mar 27, 2020

the genereated dockerconfigjson isn't correct. its not working properly with non docker runtime such as containerd.

This Charts generates:

{
    "registry.example.com": {
        "auth": "asdfasdf",
        "password": "test123",
        "username": "dummy"
    }
} 

What it actually should generate:

{
    "auths": {
        "registry.example.com": {
            "username": "dummy",
            "password": "test123",
            "auth": "asdfasdf"
        }
    }
}
@gabibbo97
Copy link
Owner

So it's missing a }? Which chart and version?

@Vad1mo
Copy link
Author

Vad1mo commented Apr 2, 2020

ahh sorry for not formattig it correctly.,

See: https://helm.sh/docs/howto/charts_tips_and_tricks/#creating-image-pull-secrets

this is how it should be:

{{- define "imagePullSecret" }}
{{- printf "{\"auths\": {\"%s\": {\"auth\": \"%s\"}}}" .Values.imageCredentials.registry (printf "%s:%s" .Values.imageCredentials.username .Values.imageCredentials.password | b64enc) | b64enc }}
{{- end }}

your chart wasn't working for me on containerd I had to change it. I guess it only works with older docker versions.

@gabibbo97
Copy link
Owner

Are you speaking of the imagepullsecrets or the pullsecret chart?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants