Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): simplify main branch check #508

Merged
merged 2 commits into from
Feb 12, 2025
Merged

fix(ci): simplify main branch check #508

merged 2 commits into from
Feb 12, 2025

Conversation

korikuzma
Copy link
Contributor

No description provided.

@korikuzma korikuzma added priority:high High priority ci/cd Continuous integration and continuous delivery/deployment changes labels Feb 12, 2025
@korikuzma korikuzma requested a review from larrybabb February 12, 2025 15:32
@korikuzma korikuzma self-assigned this Feb 12, 2025
@korikuzma korikuzma requested review from a team as code owners February 12, 2025 15:32
@jsstevenson
Copy link
Contributor

jsstevenson commented Feb 12, 2025

is there a reason we aren't just spec'ing the branch name under the workflow triggers?

edit: or something like if: github.ref == 'refs/heads/main' under the job itself

@korikuzma
Copy link
Contributor Author

@jsstevenson No, could you post the change? I just need a quick fix to make a release

Copy link
Contributor

@larrybabb larrybabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kori rocks!

@jsstevenson
Copy link
Contributor

@korikuzma I think that commit should do it (fingers crossed)

@korikuzma korikuzma changed the title fix(ci): exclude HEAD from git branch output in pypi release job fix(ci): simplify main branch check Feb 12, 2025
@korikuzma korikuzma merged commit db4ea0d into main Feb 12, 2025
14 checks passed
@korikuzma korikuzma deleted the fix-pypi branch February 12, 2025 15:57
korikuzma added a commit that referenced this pull request Feb 12, 2025
korikuzma added a commit that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continuous integration and continuous delivery/deployment changes priority:high High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants