Should relation or relations be renamed?

[brendanreardon]

At the 2025-02-05 meeting, there was extensive discussion on if relations should be a mappableConcept?. One component of the conversation was if relation or relations should be renamed. Examples given in the meeting were matchType for relation and either transformsTo or relatesTo for relations.

While relation is a required property for the ConceptMapping class from gks-core, creating the Discussion here as it is equally applicable to the relations property within DefiningAlleleConstraint and DefiningLocationConstraint.

What do people think?

[larrybabb]

I might suggest that both attributes get renamed so that they are much clearer in what they are meant to convey. Maybe the ConceptMapping.relation could become ConceptMapping.matchType. And DefiningAlleleConstraint.relations could become DefiningAlleleConstraint.derivationMethods or derivationTypes to indicate the method or type of derivations that are allowed to be included based on the DefiningAlleleConstrating.alleleContext. Also NOTE this would apply equally to DefiningLocationConstraint.