Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SizeName property to label to control text size #5570

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

dweymouth
Copy link
Contributor

@dweymouth dweymouth commented Feb 28, 2025

Description:

Allows for controlling the text size of a Label widget. Especially useful with selection support landing in 2.6 as the only other way to customize the size of selectable text would be a ThemeOverride container, which is heavyweight and verbose.

This mirrors the API that already exists for Hyperlink sizing.

Fixes #5561

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style and have Since: line.

@dweymouth dweymouth changed the title Add SizeName property to label Add SizeName property to label to control text size Feb 28, 2025
@coveralls
Copy link

coveralls commented Feb 28, 2025

Coverage Status

coverage: 62.311% (-0.09%) from 62.402%
when pulling b394d19 on dweymouth:label-style
into 4cd00b5 on fyne-io:develop.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this really needs some tests, make sure the label is scaling appropriately, updates on change and that the selection follows it...

@dweymouth dweymouth requested a review from andydotxyz March 2, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants