Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving inner window theme #5468

Merged
merged 4 commits into from
Jan 26, 2025
Merged

Conversation

andydotxyz
Copy link
Member

@andydotxyz andydotxyz commented Jan 26, 2025

Also added some dummy handlers to the demo to show difference of disabled / default.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.
  • Public APIs match existing style and have Since: line.
Screen.Recording.2025-01-26.at.20.33.09.mov

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks so much better. Can you please make the contrast for hovering the buttons higher because I find it on the edge of being hard to make out, especially if you move the mouse quickly.

The close button is also "very read" in an almost distracting way and pops out a bunch when hovered. I wonder if we should just make it match hover for the other buttons?

@andydotxyz
Copy link
Member Author

Thanks. This looks so much better. Can you please make the contrast for hovering the buttons higher because I find it on the edge of being hard to make out, especially if you move the mouse quickly.

The close button is also "very read" in an almost distracting way and pops out a bunch when hovered. I wonder if we should just make it match hover for the other buttons?

What you're asking for really requires a whole new set of colours for hover and therefore likely others like focus etc.
I think that is way beyond what we need so instead I have removed the custom colours completely.

Revised:

Screen.Recording.2025-01-26.at.20.39.35.mov

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. That looks better contrast wise 👍

@andydotxyz
Copy link
Member Author

Failures in pref test only - that's on another PR for discussion

@andydotxyz andydotxyz merged commit 04d17a5 into fyne-io:develop Jan 26, 2025
1 of 10 checks passed
@andydotxyz andydotxyz deleted the fix/windowtheme branch January 26, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants