-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving inner window theme #5468
Conversation
And make it more themeable too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This looks so much better. Can you please make the contrast for hovering the buttons higher because I find it on the edge of being hard to make out, especially if you move the mouse quickly.
The close button is also "very read" in an almost distracting way and pops out a bunch when hovered. I wonder if we should just make it match hover for the other buttons?
What you're asking for really requires a whole new set of colours for hover and therefore likely others like focus etc. Revised: Screen.Recording.2025-01-26.at.20.39.35.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. That looks better contrast wise 👍
Failures in pref test only - that's on another PR for discussion |
Also added some dummy handlers to the demo to show difference of disabled / default.
Checklist:
Screen.Recording.2025-01-26.at.20.33.09.mov