Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fyne.Do error reporting #5465

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

andydotxyz
Copy link
Member

Checklist:

  • Tests included. <- should stop seeing the reports in tests
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 59.05% (+0.02%) from 59.034%
when pulling 38b6a17 on andydotxyz:fix/fynedologline
into bb1657e on fyne-io:develop.

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this but it still doesn't seem to get the right line. Adding a go statement before the first w.Resize() call in fyne_demo gives me this:

2025/01/26 20:49:04 *** Error in Fyne call thread, this should have been called in fyne.Do[AndWait] ***
2025/01/26 20:49:04   From: /var/home/jacob/git/fyne/internal/driver/glfw/window.go:242

internal/driver/common/canvas.go Outdated Show resolved Hide resolved
Co-authored-by: Jacob Alzén <jacalz@tutanota.com>
@andydotxyz
Copy link
Member Author

andydotxyz commented Jan 26, 2025

Thanks for this but it still doesn't seem to get the right line. Adding a go statement before the first w.Resize() call in fyne_demo gives me this:

2025/01/26 20:49:04 *** Error in Fyne call thread, this should have been called in fyne.Do[AndWait] ***
2025/01/26 20:49:04   From: /var/home/jacob/git/fyne/internal/driver/glfw/window.go:242

When testing inside the fyne codebase it is not possible to deduce where the line between library and app are.
Try with one of your apps or anything in a different repo...

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a merge for test fixes

@andydotxyz andydotxyz merged commit 4717318 into fyne-io:develop Jan 28, 2025
1 of 10 checks passed
@andydotxyz andydotxyz deleted the fix/fynedologline branch January 28, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants