Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better ci infrastructure #5445

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Jan 21, 2025

Description:

Various changes to make it easier to maintain (or rather have it maintain itself) and also some cleanups plus simplifications.

  • Moved the licence check workflow run into the static analysis test.
  • Stop running benchmarks on CI, no one looks at this output and it doesn't fail or notify us if performance goes bad so there is really very little gain from the extra time it takes. Let's add some specific benchmark workflow in the future instead if necessary.
  • Use latest Go version automatically to avoid having to change required versions each time.
  • Switch to actions/setup-go which is better maintained and has built in dependency caching infrastructure (a fresh build after go.mod changes is likely slower but we avoid downloading dependencies for all else).
  • Load version from go.mod automatically using workaround until Use version from module and another version in matrix testing actions/setup-go#450 is implemented.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

No one looks at this output and it doesn't fail or notify us if performance goes bad so there is really very little gain from the extra time it takes.
Has built in caching so we might get faster builds for incremental builds where dependencies hasn't changed.
@coveralls
Copy link

coveralls commented Jan 21, 2025

Coverage Status

coverage: 59.044% (+0.009%) from 59.035%
when pulling 3269857 on Jacalz:better-ci-infrastructure
into 8726c8b on fyne-io:develop.

@Jacalz Jacalz force-pushed the better-ci-infrastructure branch from 9c58ec2 to 5e2aaf5 Compare January 21, 2025 11:39
andydotxyz
andydotxyz previously approved these changes Jan 21, 2025
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@Jacalz
Copy link
Member Author

Jacalz commented Jan 21, 2025

Thanks. Feel free to update required workflows and merge when you are ready :)

use workaround until actions/setup-go#450 is implemented.
@Jacalz
Copy link
Member Author

Jacalz commented Jan 21, 2025

I added a little change so we can load the version from go.mod automatically. With this, we should basically don't have to touch workflows much going forward. They should mostly maintain themselves. The downside is that workflow naming is a bit convoluted (one being called nothing and one being called stable but I think it is worth it). Once actions/setup-go#450 lands, it will likely be go.mod and stable :)

@andydotxyz
Copy link
Member

Perfect thanks, I think that is the settings updated

@Jacalz
Copy link
Member Author

Jacalz commented Jan 24, 2025

Great. Just an approval needed before it can be merged :)

@Jacalz Jacalz merged commit 22234be into fyne-io:develop Jan 24, 2025
11 checks passed
@Jacalz Jacalz deleted the better-ci-infrastructure branch January 24, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants