Fix *BSD systems using the wrong (and slow) window resize #4409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this ought to go into a v2.4.x release when merged. |
|
Oh, nice! Going to try this later on OpenBSD. Noticed it before, but didn't start debugging since I'm also hacking on the window manager I'm using and couldn't rule out that it wasn't my fault so far as I'm actually working on window resizing logic. |
|
Tested and works as intended on OpenBSD. |
|
Thanks for testing 👍 |
andydotxyz
approved these changes
Nov 26, 2023
Jacalz
force-pushed
the
wrong-resize-on-bsd
branch
from
4c97c6d to
2c5349f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I realized that we had decided to group Linux into its own implementation without considering that *BSD systems would want to use the same fast file path.
Draft: Currently untested on BSD. The logic is sound and I just didn't forget my branch so opened.
Checklist: