Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Remove to data binding lists and trees #4389

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Add Remove to data binding lists and trees #4389

merged 5 commits into from
Dec 6, 2023

Conversation

andydotxyz
Copy link
Member

@andydotxyz andydotxyz commented Nov 15, 2023 •
edited
Loading

Adding the missing functions.
Removing a tree item removes all its children.

Fixes #3100

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.
  • Public APIs match existing style and have Since: line.

@andydotxyz andydotxyz marked this pull request as ready for review November 16, 2023 22:06
@andydotxyz andydotxyz requested a review from Jacalz November 16, 2023 22:06
@andydotxyz
Copy link
Member Author

Naming to be checked here I guess. List might add RemoveIndex in the future, should there be an equivalent for Map and/or should Remove be RemoveKey? I was following the Golang delete as passing the key but that may not fit with our API design.

@Jacalz
Copy link
Member

Jacalz commented Nov 21, 2023

I'll try to have a look tomorrow or on Thursday if possible.

Jacalz
Jacalz requested changes Nov 27, 2023
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. I have two thoughts inline.

@andydotxyz
Copy link
Member Author

Thanks, I think it should all be sorted now.

Jacalz
Jacalz requested changes Dec 6, 2023
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just some staticcheck fixes that need to be done now that it apparently understands what v is (bug?).

@Jacalz Jacalz mentioned this pull request Dec 6, 2023
Open
@andydotxyz
Copy link
Member Author

Oh good point I missed that. It was a bug that was hiding. Added a new test to confirm

@andydotxyz andydotxyz merged commit 798b13b into fyne-io:develop Dec 6, 2023
@andydotxyz andydotxyz deleted the fix/3100 branch December 6, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andydotxyz @Jacalz