Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current version of puppeteer no longer supported #84

Open
adbutterfield opened this issue Mar 29, 2023 · 4 comments
Open

Current version of puppeteer no longer supported #84

adbutterfield opened this issue Mar 29, 2023 · 4 comments

Comments

@adbutterfield
Copy link

Hello!

Awsome package. (I also used to use react-screenshot-test before this)

On install, we get a deprecation warning:

npm WARN deprecated puppeteer@10.4.0: < 19.2.0 is no longer supported

Any reason to keep on that version? I'm happy to make a PR for upgrade if not.

@fwouts
Copy link
Owner

fwouts commented Mar 29, 2023

Hey @adbutterfield, the only reason is that this package isn't maintained anymore. Happy to merge and publish a PR though.

@adbutterfield
Copy link
Author

By "this package isn't maintained anymore" you mean viteshot?

@fwouts
Copy link
Owner

fwouts commented Mar 29, 2023

Sorry I thought this was an issue on react-screenshot-test 🙂 This one isn't actively maintained at the moment but I do intend to get it back up to date at some point!

PR welcome.

@fwouts
Copy link
Owner

fwouts commented Apr 10, 2023

Hey @adbutterfield, I was looking at updating Viteshot, then I realised it might benefit from becoming a simple library instead of a CLI so you have a little more flexibility with it.

I published that alternative approach as https://www.npmjs.com/package/@previewjs/screenshot.

I'm curious what your thoughts are on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants