Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use fs-fixture instead of memfs #23

Merged
merged 4 commits into from
Oct 11, 2024
Merged

test: use fs-fixture instead of memfs #23

merged 4 commits into from
Oct 11, 2024

Conversation

fvsch
Copy link
Owner

@fvsch fvsch commented Oct 11, 2024

Use real node:fs API to run tests that need filesystem access, with fs-fixture.

This lets us:

  • remove memfs (which has some limitations and differences in behavior)
  • remove the FSProxy abstraction

@fvsch fvsch merged commit dc44012 into main Oct 11, 2024
1 check passed
fvsch added a commit that referenced this pull request Oct 11, 2024
@fvsch
refactor: remove unnecessary fs abstraction (#23)
05ea372
@fvsch fvsch deleted the fvsch/test-fs-fixture branch October 11, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fvsch