You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue description:
Plugin adds sns:Publish permission in case if function has onError definition and doesn't take into account that it might be SQS resource arn
Steps to reproduce:
Define any function with onError property mapped to SQS resource:
Serverless added support for DQL setup with onError function property here. However it has some strange concurrency issue described in docs. But still community has some workarounds and moreover, it's hard to reproduce it (that's why it's not fixed yet), so that most people (like me) use it as is without any issues.
TBD:
As possible solution I recommend to delete additional policy definitions in case if onError property set in function definition.
In case if we want to keep backward compatibility we may add configuration property like addOnErrorPolicy: boolean.
Looking forward for your comments,
Thanks in advance.
The text was updated successfully, but these errors were encountered:
Issue description:
Plugin adds
sns:Publish
permission in case if function hasonError
definition and doesn't take into account that it might be SQS resource arnSteps to reproduce:
onError
property mapped to SQS resource:sls deploy
Expected result:
No useless permissions should be added
Current result:
Useless permissions added:
Background:
Serverless added support for DQL setup with
onError
function property here. However it has some strange concurrency issue described in docs. But still community has some workarounds and moreover, it's hard to reproduce it (that's why it's not fixed yet), so that most people (like me) use it as is without any issues.TBD:
As possible solution I recommend to delete additional policy definitions in case if
onError
property set in function definition.In case if we want to keep backward compatibility we may add configuration property like
addOnErrorPolicy: boolean
.Looking forward for your comments,
Thanks in advance.
The text was updated successfully, but these errors were encountered: