Specialize (type) keywords as independent token kinds #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuhsnn
force-pushed
the
main
branch
7 times, most recently
from
f093a17 to
bfe2374
Compare
ChAoSUnItY
force-pushed
the
token-type-specialize
branch
from
03a4f71 to
a5b7c6a
Compare
|
Your team submitted three patches in a row #89 (comment), #90 (comment), #93 (comment) that ended up almost identical with another author's chibicc fork, that really drained my motivation to look at your PRs on unnecessary changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR specializes every keyword tokens into independent kinds, reduces each keyword token string comparison to once per compilation, in other words, keywords will be identified in tokenization phase.