Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete rewrite for v2 #25

Open
callumlocke opened this issue Jul 17, 2017 · 0 comments
Open

Complete rewrite for v2 #25

callumlocke opened this issue Jul 17, 2017 · 0 comments

Comments

@callumlocke
Copy link
Contributor

callumlocke commented Jul 17, 2017

Tentative plan:

  • Make a new repo at financial-times/ig-onward-journey (and add deprecation notice and link to old repo's readme)
  • Write a readme that states what the app is for, and lists the endpoints with examples and clear explanations of how they will be consumed
  • Set up the new repo to auto-deploy to ft-ig-onward-journey on Heroku, with PR review apps
    • Ideally also rename the old app to ft-ig-onward-journey-legacy and update the Apache config on the IG server accordingly
  • Make a new entry in the Next service registry for /__ig-onward-journey
  • The new app's routes all start with /v2, and it uses CAPI v2 (see Add support for CAPI v2 #24)
    • Do not bother writing backwards-compatible /v1 routes – the old Heroku app will continue to serve these for old clientside apps still using it
  • Probably use micro to write the app, and probably avoid Babel (just use Node 8 for async functions)
  • Write tests for each endpoint, and get them running on CircleCI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant