Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Testing Fixtures #80

Open
5 tasks
RRosio opened this issue Feb 18, 2025 · 1 comment
Open
5 tasks

Refactor Testing Fixtures #80

RRosio opened this issue Feb 18, 2025 · 1 comment
Labels
testing

Comments

@RRosio
Copy link
Collaborator

RRosio commented Feb 18, 2025

  • Refactor test fixtures to eliminate unnecessary one-time-use fixtures by incorporating their setup directly into the test
  • Decouple test_filesystem_manager.py tests from test_api.py state
  • ResolveUnclosed client session error on s3 instance tests
    • Split up upload/download sync and verify/document behavior as expected
    • Resolve polluted state in between tests with s3 filesystem interaction
@RRosio RRosio added the testing label Feb 18, 2025
@martindurant
Copy link
Member

eliminate unnecessary one-time-use fixtures by incorporating their setup

It can be useful to know whether setup failed or the test failed. Some setup within tests is normal, and the line between the two is blurry.

@RRosio RRosio mentioned this issue Feb 19, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martindurant @RRosio