Add the verbose option in loading #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jja725
reviewed
May 24, 2024
alluxiofs/client/core.py
Outdated
| @@ -369,13 +369,15 @@ def load( | |||
| self, | |||
| path, | |||
| timeout=None, | |||
| verbose=False, | |||
There was a problem hiding this comment.
set it to true by default because I feel like it's usually used when the job failed...
There was a problem hiding this comment.
Sure. Set the default value of verbose to True in all load APIs.
|
What will the verbose parameter changes on the end-user side from Python API? |
|
LuQQiu
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the verbose option for dataset loading has been supported in the REST API endpoints, this PR adds the verbose option in the python client.