Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double coercion and error messages fixes #507

Merged
merged 4 commits into from
Dec 7, 2024
Merged

Double coercion and error messages fixes #507

merged 4 commits into from
Dec 7, 2024

Conversation

xperiandri
Copy link
Collaborator

  1. Because coercion collections were of type seq the error-splitting logic called them twice causing double execution
  2. Because collections passed to input object fields mismatch validation were not F# collections their string values used to not appear in the exception message.

@xperiandri xperiandri requested a review from valbers December 7, 2024 21:04
valbers
valbers approved these changes Dec 7, 2024
View reviewed changes
Copy link
Collaborator

@valbers valbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xperiandri xperiandri merged commit 20646ca into dev Dec 7, 2024
3 checks passed
@xperiandri xperiandri deleted the double-coercion-fix branch December 7, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valbers valbers valbers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xperiandri @valbers