Relay Revamp #484
Merged
Relay Revamp #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow! Cool! I’ll review this weekend |
I need to update a few more things to fix the build first 👍 |
|
Let's migrate to |
Now ready 👍 |
xperiandri
requested changes
Aug 31, 2024
There was a problem hiding this comment.
@njlr amazing job! Could you address a few remarks, please?
|
@njlr if you can address that for tomorrow I will review and merge that immediately and issue the new version of the packages as I want to use your new changes |
|
Comments addressed 👍 |
xperiandri
approved these changes
Sep 1, 2024
xperiandri
approved these changes
Sep 1, 2024
xperiandri
approved these changes
Sep 1, 2024
xperiandri
force-pushed
the
relay-revamp
branch
2 times, most recently
from
bd8ded6 to
8d6bb09
Compare
xperiandri
force-pushed
the
relay-revamp
branch
from
8d6bb09 to
9d1b50a
Compare
|
Amazing! @njlr have a look at my last changes |
* Add a relay sample that fetches data efficiently from SQLite
Co-authored-by: Andrii Chebukin <XperiAndri@Outlook.com>
Co-authored-by: Andrii Chebukin <XperiAndri@Outlook.com>
Co-authored-by: Andrii Chebukin <XperiAndri@Outlook.com>
Co-authored-by: Andrii Chebukin <XperiAndri@Outlook.com>
xperiandri
force-pushed
the
relay-revamp
branch
from
9d1b50a to
f2cf145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing relay pagination code was synchronous, and therefore not usable against a real data-store.
This PR makes the types async and introduces some strong typing. This is a breaking change.
I also removed the old Relay sample, which no longer works anyway, and have added a new pagination sample.
The sample queries data from SQLite, which shows that it can work for real data-stores. It is efficient in terms of data-fetching.