ID type deserialization fix with field tests
#427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xperiandri
force-pushed
the
ID_type_deserialization_fix_with_field_tests
branch
2 times, most recently
from
31b5860 to
785c605
Compare
|
Probably we need to modify some tests too |
xperiandri
force-pushed
the
ID_type_deserialization_fix_with_field_tests
branch
from
785c605 to
47fb668
Compare
xperiandri
changed the title
ID type deserialization fix with field tests
valbers
requested changes
Oct 15, 2023
xperiandri
force-pushed
the
ID_type_deserialization_fix_with_field_tests
branch
from
47fb668 to
29fede5
Compare
xperiandri
force-pushed
the
dev
branch
4 times, most recently
from
c8b3525 to
0810527
Compare
xperiandri
force-pushed
the
ID_type_deserialization_fix_with_field_tests
branch
from
29fede5 to
bcb5e88
Compare
xperiandri
force-pushed
the
dev
branch
2 times, most recently
from
14aa27a to
3ba4016
Compare
xperiandri
force-pushed
the
dev
branch
2 times, most recently
from
1737829 to
246d6c0
Compare
xperiandri
force-pushed
the
dev
branch
2 times, most recently
from
0dd4372 to
81bc85e
Compare
xperiandri
force-pushed
the
ID_type_deserialization_fix_with_field_tests
branch
from
bcb5e88 to
a9938a1
Compare
Deserialization of ID types caused an exception if the field was nullable.
xperiandri
force-pushed
the
ID_type_deserialization_fix_with_field_tests
branch
from
a9938a1 to
87f2225
Compare
|
I'll believe in you and assume I'm missing something. Let's close this PR. |
valbers
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ivelten I think testing should happen from here.
Also, we can change some
idfields on StarWars API to cover different scenarios