Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme in Display Settings is applied without pressing save #156

Open
5argon opened this issue Jan 30, 2025 · 1 comment
Open

Theme in Display Settings is applied without pressing save #156

5argon opened this issue Jan 30, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@5argon
Copy link
Contributor

5argon commented Jan 30, 2025

Most settings in the https://arkham.build/settings page requires pressing the "Save settings" button to confirm, otherwise it reverts to the previous value. However, only the Theme settings stays as previewed without pressing Save.

Image Image
@5argon 5argon added the bug Something isn't working label Jan 30, 2025
@fspoettel
Copy link
Owner

This one is a bit tricky - we need to save the theme to local storage so we can apply it synchronously immediately. The rest of the settings is loaded async in app bootstrap. Needs a bit of extra logic to make it consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants