Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adjusting how filters combine #146

Open
LastTalon opened this issue Jan 12, 2025 · 4 comments
Open

Allow adjusting how filters combine #146

LastTalon opened this issue Jan 12, 2025 · 4 comments

Comments

@LastTalon
Copy link

Often, when trying to filter for specific sorts of cards (or decks) I lack fine-grain control over which are displayed based on how filters combine.

The default filter combination seems to be "any of" within a category, but "all of" between categories. It would be useful to have more fine-grain control over this, or even more precise filter combinators (or, and, not, etc.).

As an example, I may be looking for an asset that has both the "Blessed" and "Relic" traits, but the way filters currently combine, I can only filter to assets that are "Blessed" and/or "Relic" but not specifically cards that are both simultaneously.

@fspoettel
Copy link
Owner

This is a good idea and something we will have to implement in the not-so-distant future. If done correctly, this would also allow for serializing the filters to a string format, thereby allowing to type them and persist them to the URL later on.

@LastTalon
Copy link
Author

I'm not sure if I'll get to it with this issue, but sometime in the future I'm considering contributing. I am a bit intimidated by my unfamiliarity with the tech stack. I'm not sure if you have any pointers as far as what I'd need to know to set up the environment and work on contributing features like this one.

@fspoettel
Copy link
Owner

Yeah, this is not exactly a good first issue as it requires intimate knowledge not only of the stack, but also of our app. I labelled some things as good first issues and will continue to do so, maybe you will find something interesting in there.

@fspoettel
Copy link
Owner

fspoettel commented Jan 14, 2025

I'm not sure if you have any pointers as far as what I'd need to know to set up the environment

@LastTalon The Development section in the readme should have pointers. The only system requirement is Node.js.

If you need help getting set up, you are welcome to message me on discord or post in dedicated thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants