Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slam yaml params #395

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Slam yaml params #395

merged 3 commits into from
Feb 20, 2025

Conversation

marhcouto
Copy link
Contributor

@marhcouto marhcouto commented Feb 19, 2025

@DiogoProPrayer @Davide64-dev @yvesb04 @Flopes55

  • check the way the configuration loading is done by the SLAMParameters structure instead of a static function in the node, which I think looks cleaner
  • check the documentation on each parameter in the configuration files. There was documentation in the launch files, and it is fundamental at least for the string parameters
  • @DiogoProPrayer there are duplicate parameter configuration structures in the path planning package, check that out

@marhcouto marhcouto merged commit 8aa2807 into dev Feb 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants