FSF-7164 | Path Planning Integration Tests Creation #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added test to available dashboards * Added test test to send bucket * canceled previous change and added change to get dashboard layout * same as 2nd commit * Added graph 4 * Fixed errors in code structure and added graph 5 * Fixed errors in code structure and added graph 5 * Tried to add random variables * Same and Debugging * Debugging * Revert "Fixed errors in code structure and added graph 5" This reverts commit 095fe49. * Revert "Tried to add random variables" This reverts commit d05a3f0.
added launch files for more disciplines in pacsim fixed error in control node due to acos not clamped to [-1, 1], resulting in NaN steering fixed car model not appearing in foxglove
…tool. Modified some parameters
…eate tests and how to visualize the results
…the first pathpoint in the debug script
Davide64-dev
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Overall good. Three Suggestions:
- Remove the output from results, i think it does not make a lot og sense to save and those values should be on -gitignore
- I think the ground truth (x1,x2,y1,y2) should be on the .txt file corresponding to the scenario
- Some test code could be a function and with that, we would increase the code readability
Davide64-dev
approved these changes
Feb 16, 2025
|
I think everythink is alright, can you just put the tests in a way relaxed enough to not fail the tests? |
lourenco31
requested changes
Feb 16, 2025
…l+z and more minor fixes related to matplotlib deafult shortcuts
|
lourenco31
requested changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a script to generate test files
Created code to read from the file, test the pipeline and output a debug file
Created tests for all the test files from rosbags and invented scenarios
Created a script to read the debug files and plot the resulting path along with the given cones
Finally added a README.md file to help understand how the file structure works and how to create new tests in the future