PR: from dyn to master #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into threadsafe
shinnya
reviewed
Dec 4, 2018
| @@ -295,7 +294,9 @@ impl ErasureCoder { | |||
| } | |||
| impl Drop for ErasureCoder { | |||
| fn drop(&mut self) { | |||
| let _ = c_api::instance_destroy(self.desc); | |||
| with_global_lock(|| { | |||
There was a problem hiding this comment.
Could you please add a short description which describes why we must use a global lock here?
sile
reviewed
Dec 9, 2018
| @@ -29,6 +29,16 @@ For example, on Ubuntu, you can install those by executing the following command | |||
| $ sudo apt install gcc git make automake autoconf libtool | |||
| ``` | |||
|
|
|||
| Before do `cargo build`, please set the two environment variables `FRUGALOS_DIR` and `LD_LIBRARY_PATH` | |||
There was a problem hiding this comment.
依存関係的には、liberasurecodeはfrugalosに依存しないより汎用的なライブラリとしても使えるものだと思うので、個人的には FRUGALOS_DIR もそれを反映した名前(e.g., LIBERASURECODE_DIR)の方が好みです。
ただ、今回の修正でlibfrugalos内の他の個所にも結構frugalosという用語が出てくるようになって、それらを全て置き換えるのも手間だと思うので、別にこのままでも大丈夫です。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
動的リンクベースでopenstack/liberasurecodeを用いるためのPR