-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build warnings under Angular 17 #537
Comments
Any updates on this? |
1 similar comment
Any updates on this? |
@russelg I am very curious; -how did you find the code it is complaining about? ▲ [WARNING] This case clause will never be evaluated because it duplicates an earlier case clause [duplicate-case]
The earlier case clause is here:
...and I don't even know where to start looking. |
I have the same error while trying to update an angular application to 19 and the latest Froala. I've taken froala out of the application and still get this error. And as Superrole commented, I can't find any reference to that partial line of code. |
I finally found the "source" of my warning. By randomly searching through script files included in angular.json's "scripts":[]. I found it in a non public (company internal) dependency built with web-components. I am sorry for the flooding of this thread with something clearly unrelated to froala, but it was the only relevant hit on google for this issue. And hopefully it will ease the frustration of others finding themselves fumbling in the dark on a similar bug-hunt. |
angular-froala-wysiwyg/froala v4.1.3.
I have been seeing this warning when building my angular projects that use Froala:
The code in question it is complaining about comes from Froala (specifically the filesManager plugin):
Not sure if this report belongs in the angular repo, or the editor repo (https://github.com/froala/wysiwyg-editor).
However, this warning was not visible until we updated to angular 17 (and therefore esbuild as the builder).
The text was updated successfully, but these errors were encountered: