Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

passkey check weights #2059

Merged
merged 7 commits into from
Jul 10, 2024
Merged

passkey check weights #2059

merged 7 commits into from
Jul 10, 2024

Conversation

aramikm
Copy link
Collaborator

@aramikm aramikm commented Jul 6, 2024 •
edited
Loading

Goal

The goal of this PR is

Related to #2032

Discussion

Checklist

  • Chain spec updated
  • Tests added
  • Weights updated

@aramikm aramikm changed the title [WIP] passkey check weights passkey check weights Jul 8, 2024
aramikm
aramikm commented Jul 8, 2024
View reviewed changes
pallets/passkey/src/lib.rs Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jul 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
pallets/passkey/src/lib.rs 95.30% <100.00%> (+0.72%) ⬆️

@aramikm aramikm marked this pull request as ready for review July 8, 2024 20:16
@aramikm aramikm requested a review from wilwade as a code owner July 8, 2024 20:16
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jul 8, 2024
saraswatpuneet
saraswatpuneet approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

aramikm
aramikm commented Jul 9, 2024
View reviewed changes
pallets/passkey/src/lib.rs Outdated Show resolved Hide resolved
shannonwells
shannonwells approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issues

enddynayn
enddynayn approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great!

@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Jul 10, 2024
@aramikm aramikm enabled auto-merge (squash) July 10, 2024 00:54
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jul 10, 2024
@aramikm aramikm merged commit d2bef1b into main Jul 10, 2024
27 checks passed
@aramikm aramikm deleted the passkey_check_weights branch July 10, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saraswatpuneet saraswatpuneet saraswatpuneet approved these changes

@shannonwells shannonwells shannonwells approved these changes

@enddynayn enddynayn enddynayn approved these changes

@mattheworris mattheworris Awaiting requested review from mattheworris

@JoeCap08055 JoeCap08055 Awaiting requested review from JoeCap08055

@claireclark1 claireclark1 Awaiting requested review from claireclark1

@wilwade wilwade Awaiting requested review from wilwade wilwade is a code owner

Assignees
No one assigned
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aramikm @shannonwells @enddynayn @saraswatpuneet