Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpdisco: nameservice: fix function is_v4 #460

Open
spolack opened this issue Dec 22, 2024 · 0 comments
Open

bgpdisco: nameservice: fix function is_v4 #460

spolack opened this issue Dec 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@spolack
Copy link
Member

spolack commented Dec 22, 2024

function is_v4(ip) {
  if (substr(':'))
    return false;
  return true;
}

Current function makes no sense, it doesnt use the passed ip and substr is also not a viable option to check if a string contains a substring. index might be a better choice :)

@spolack spolack added the bug Something isn't working label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant