-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle citation strings #62
base: main
Are you sure you want to change the base?
Conversation
Closes #61
This didn't change on my local machine after running black, but GitHub demanded it. This is uglier. :(
for more information, see https://pre-commit.ci
This reverts commit 0be4ccd.
Not sure when this showed up!
Bill, I think it's our fault that there are conflicts here, since we didn't review it when it was clean. When you get this prioritized, can you plan to fix those for poor @anseljh, who's just trying to be a good contributor and doesn't deserve merge conflicts (not that any of us do, but, him less than us). |
I think there may be a little more to it than that with the failing tests, unfortunately. @flooie, might be good to sync up some time this week. |
I’m happy to fix it. I wasn’t sure from the last comment to hold up or what not. |
Thanks, Bill. Here's what I have failing locally now. Ping me if you'd like to talk after poking around a bit. % python setup.py test
|
This looks like an issue caused by overlapping bankruptcy issues I bet it’ll be easy to fix. |
@anseljh - I'm reviewing this PR at the moment. I've noticed what appear like extra something like this for Alakaska, Iowa or Courts ending in numbers for example.
These are atleast contributing to the failing tests and I'm not sure if they were intentional or not. Ive found about 20 or so. I assume they aren't but I wanted to double check. |
Yeah, I agree, those don't look right, @flooie. |
So, There are a couple of issues, but they all seem a bit minor. Thanks for getting this rolling @anseljh |
Closes #61