Restore: Added ordering_key to the Opinions index #5005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit eead694.
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
| @@ -190,6 +190,7 @@ def midnight_pt_test(d: datetime.date) -> datetime.datetime: | |||
| "snippet": lambda x: ( | |||
| x["snippet"] if x.get("snippet") else x["result"].plain_text or "" | |||
| ), | |||
| "ordering_key": lambda x: x["result"].ordering_key, | |||
There was a problem hiding this comment.
Semgrep identified an issue in your code:
return only makes sense inside a function
To resolve this comment:
🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.
💬 Ignore this finding
Leave a nosemgrep comment directly above or at the end of line 193 like so // nosemgrep: python.lang.maintainability.return.return-not-in-function
Take care to validate that this is not a true positive finding before ignoring it.
Learn more about ignoring code, files and folders here.
You can view more details about this finding in the Semgrep AppSec Platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's restore the
ordering_keyto the opinions index once https://github.com/freelawproject/infrastructure/issues/269 is completed.