infra/image/shdefaults: Add SYS_PTRACE to CAP_DEFAULTS

[t-woerner]

Debugging is now enabled by default in the containers that are generated with container_create. "+SYS_PTRACE" has been added to CAP_DEFAULTS in shdefaults for this.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces a new -d option to the start.sh script, enabling debugging within the container by adding the SYS_PTRACE capability. This allows users to attach a debugger to processes running inside the container.

Sequence diagram for starting the container with debugging enabled

sequenceDiagram
    participant S as start.sh
    participant C as container_create
    participant container_start
    participant container_wait_for_journald
    participant container_wait_up

    S->>S: Parses arguments, including -d
    alt -d is provided
        S->>C: container_create with SYS_PTRACE capability
    else -d is not provided
        S->>C: container_create without SYS_PTRACE capability
    end
    C-->>S: Container created
    S->>container_start: container_start
    container_start-->>S: Container started
    S->>container_wait_for_journald: container_wait_for_journald
    container_wait_for_journald-->>S: Journald ready
    S->>container_wait_up: container_wait_up
    container_wait_up-->>S: Container is up

Loading

File-Level Changes

Change	Details	Files
Added a new -d option to enable debugging within the container by adding the SYS_PTRACE capability.	Added -d option to usage message. Added -d option parsing in getopts. Set SYS_PTRACE capability when -d is used. Pass capabilities to container_create.	infra/image/start.sh

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @t-woerner - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider using more descriptive variable names than single letters in getopts.
• It might be helpful to add a comment explaining why the SYS_PTRACE capability is required for debugging.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[rjeffman]

IMHO, this could be the default behavior.

LGTM.

[rjeffman]

LGTM